Repository navigation
Commit b120b66
fix(scripts): correct the RETIRED_FIELD_TYPES
Fixes #10070
Clause-②: no — a comment in a source file; no accept set or public
contract surface moves
## What was false, and where it actually lives
The sentence objectui#9803 corrected on the
`RETIRED_DASHBOARD_NODE_TYPES` entry has a twin on the
`RETIRED_FIELD_TYPES` entry of `INDIRECT_REGISTRATIONS` in
`scripts/check-doc-component-types.mjs`, in that entry's `excluded`
string. Before this change it read:
> Deciding it either way flips one switch and nothing else — DROP this
`excluded` line and the collection's keys (today `field:owner`) enter
the universe, so a document teaching `field:owner` turns GREEN; keep it
and such a document stays RED, which is what happens today.
The corrected copy on the dashboard entry reads, in part: "DROPPING this
`excluded` line does NOT re-admit `view:dashboard` — … it makes THIS
entry report `stale-indirect-registration`". The field entry's own
`reason` already stated the cause: "RETIRED_FIELD_TYPES is IMPORTED into
this file from `@object-ui/core`, so nothing here could read it anyway."
excluded sentence that dropping the line refutes (objectui#10070) (#10961)1 parent 97dabdc commit b120b66
2 files changed
Lines changed: 13 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1274 | 1274 | | |
1275 | 1275 | | |
1276 | 1276 | | |
1277 | | - | |
| 1277 | + | |
1278 | 1278 | | |
1279 | 1279 | | |
1280 | 1280 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
614 | 614 | | |
615 | 615 | | |
616 | 616 | | |
617 | | - | |
618 | | - | |
619 | | - | |
620 | | - | |
621 | | - | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
622 | 626 | | |
623 | 627 | | |
624 | 628 | | |
| |||
638 | 642 | | |
639 | 643 | | |
640 | 644 | | |
641 | | - | |
642 | | - | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
643 | 648 | | |
644 | 649 | | |
645 | 650 | | |
| |||
0 commit comments