Repository navigation
Commit dd3f7e1
fix(console): an injected @objectstack/client joins the vendor-objectstack chunk group (objectui#10920) (#10921)
Fixes #10920
## What broke
objectstack's `build-console.sh` always sets `OBJECTSTACK_CLIENT_DIST`
to the framework's own `packages/client`. That path is outside
`node_modules`, so the `vendor-objectstack` group test never matched the
injected client. Before #9488 the recursive `data-adapter` group
absorbed the client anyway, which hid the gap. Once #9488 made
`data-adapter` non-recursive, the client landed in `framework`.
`framework` imports `data-adapter`, through `packages/react`'s
`error-message.ts`. `data-adapter` then `require`s the CJS client from
`framework` at its top level, before `framework` has defined it. On
`9f0c84a44` the console built this way stays on the splash screen with
`TypeError: u is not a function`.
## The fix
`widenVendorChunkTestForClient` widens the group's test with the
injected client's package directory. The spec hook already does the same
for an injected spec. When nothing is injected, the test is returned
unchanged, so production and CI builds do not move.
## Evidence
- Reverse verification: the three new cases pass. With
`vendorObjectstackTest` wired back to the bare expression, only the
config-level case fails (1 red, 21 green). That case is the one that
pins the wiring.
- `pnpm exec vitest run
scripts/__tests__/vite-objectstack-client-dist.test.ts`: 22 passed.
- `pnpm type-check:scripts` and `pnpm type-check:vitest-config`: clean.
- `node scripts/check-changeset-presence.mjs`: no changeset is owed,
because no published source moved.
- End to end, with the same change applied to objectstack's build tree
at `9f0c84a44`: `chunk-membership.json` reads `client: {
"vendor-objectstack": 1 }`, the console boots to `/login`, and a
95-surface sweep of the showcase and Setup apps shows no page errors.
---
_Generated by [Claude
Code](https://claude.ai/code/session_local_f929252f-7e71-4327-b98b-bd46424b5e05)_
Co-authored-by: Jack Zhuang <50353452+hotlong@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>1 parent 1dae95a commit dd3f7e1
3 files changed
Lines changed: 122 additions & 6 deletions
File tree
- apps/console
- scripts
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
767 | 767 | | |
768 | 768 | | |
769 | 769 | | |
770 | | - | |
771 | | - | |
772 | | - | |
773 | | - | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
774 | 778 | | |
775 | 779 | | |
776 | 780 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
8 | 12 | | |
9 | 13 | | |
10 | 14 | | |
| |||
347 | 351 | | |
348 | 352 | | |
349 | 353 | | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
228 | 228 | | |
229 | 229 | | |
230 | 230 | | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
231 | 268 | | |
232 | 269 | | |
233 | 270 | | |
| |||
0 commit comments