test(app-shell): the new-hook target test waits for the roster's labels before reading them (objectui#11978) (#11986)

Fixes #11978
Clause-②: no

## What changed

One test, `ObjectHooksPanel.newHookTarget-11820.test.tsx`, "opens with
this package's objects first and every other object under the reach
warning": every read whose answer the object roster draws now waits for
that answer.

- The two "This package" checkbox reads (`Invoice (invoice)`, `Invoice
line (invoice_line)`) and the two "Other objects" checkbox reads (`User
(sys_user)`, `Employee (hr_employee)`) use `await
within(…).findByRole(…)` at the default timeout instead of a synchronous
`getByRole`.
- The "Other objects" group is found with `await screen.findByRole` too:
that group is drawn only once the roster answers.
- An empty-frontmatter changeset declares no release. The file sits
under `src/`, and `check-changeset-presence.mjs` has no carve-out for
tests.

The component is unchanged: `HookDefaultInspector`'s bare-name interim
state is deliberate (objectui#10585).

## Why it was red on timing alone

Two reads answer at their own pace.

- `ObjectHooksPanel` reads this package's objects in a mount effect and
hands them to the editor as `HookTargetScopeContext`. That draws the
"This package" group.
- `HookDefaultInspector` reads the object roster itself
(`useObjectOptions`), after New opens it. Until the roster answers,
`pickerOptions` holds only the selected object, labelled by its bare
name.

So "This package" can be on screen holding one checked checkbox named
`invoice` while "Other objects" is not drawn yet. The test awaited only
the group, then read the label synchronously. Which read answered first
decided the verdict: this is the red that took PR #11972 out of the
merge queue and turned PR #11973's `Test (shard 6/8)` red.

## Measurements, on this branch

**H1: the fix closes the window.** A throwaway, untracked copy of the
test (deleted afterwards) delays only the catalog `list('object')`
answer; the package-scoped read is not delayed. One copy of the test as
on `main` (`989b19082`), one of the test as changed here.

| copy | roster delay | runs | result |
|---|---|---|---|
| as on `main` (the lit control) | 120 ms | 3 | 3 failed, each at the
`Invoice (invoice)` read. The dump shows "This package" holding one
checked checkbox named `invoice`: the queue's signature. |
| as changed here | 120 ms | 3 | 3 passed |
| as changed here | 300 ms | 1 | passed |
| as changed here | 600 ms | 1 | passed |
| as changed here | 1500 ms | 1 | failed at the new
`findByRole('checkbox', { name: 'Invoice (invoice)' })`: the wait is
bounded by the default 1000 ms timeout. |

**H2: the test still tests its claim.** Two ablations of
`HookDefaultInspector.tsx` through objectstack's
`scripts/ablation-replace.mjs` in wrap mode. Each was restored to the
HEAD blob `3bb69262f529` with `git diff HEAD` empty, and a bash trap
re-checked the same hash.

- `invoice` moved from "This package" to "Other objects" (both
`scope.packageObjects.has(o.value)` partition reads replaced; anchor 2
to 0, blob changed). The test went red at the new `await
within(own).findByRole('checkbox', { name: 'Invoice (invoice)' })` after
its default timeout.
- The reach warning removed (the `hook-object-outside-reach` paragraph
deleted; anchor 1 to 0). Red at
`getByTestId('hook-object-outside-reach')`.
- The first attempt at the first ablation was a no-op. Its replacement
text contained the anchor, so the anchor count could not drop; the tool
refused with exit 1 before running the test, and restored. The reading
above is the retake, with a replacement that does not contain the
anchor.

**H3: the same pattern elsewhere.** Read only; no other test file is
touched. Two text scans over the 594 test files under
`packages/app-shell/src/views/studio-design/` and
`packages/app-shell/src/views/metadata-admin/`. Each has a lit positive
control: run on `main`, each hits this card's test; on this branch,
neither does.

1. An awaited container (`const X = await …findBy…`), then a synchronous
named read inside it: 15 hits in 10 files. None shares the race. The
names are static i18n strings drawn in the same commit as their
container (buttons, a tab, a placeholder). The one data-derived name,
`DocPreview.test.tsx` "keeps a group key no book declares visible", is
gated by an interposed `await waitFor(() =>
expect(picker).toHaveValue('retired_section'))`, which can pass only
once the books answered.
2. A synchronous read of a roster-shaped `Label (api_name)` name: 25
hits in 11 files. None shares the race. Most are synchronous renders
with no async read at all (static strings such as `Values (measures)`,
`role (deprecated)`). `HookDefaultInspector.reach-11820.test.tsx` awaits
`findByRole('checkbox', { name: 'Account (crm_account)' })`, the
roster's answer, before its synchronous reads.
`AccessExplainPanel.test.tsx` waits for the Object field to become a
select, which is drawn once the roster answered.
`ObjectFieldInspector.usePicklist-10202.test.tsx` awaits one served
option before reading its sibling from the same answer.

The scans' blind spot: a data-derived name in another form, read through
`screen.getBy…` after an unrelated await, is outside both.

## Gates, at `04a3cad2a`

- `pnpm exec vitest run --maxWorkers=2
packages/app-shell/src/views/studio-design/
packages/app-shell/src/views/metadata-admin/inspectors/` (verify lock):
`Test Files 296 passed (296)`, `Tests 2935 passed | 1 skipped (2936)`.
- `pnpm exec vitest run --maxWorkers=2 scripts/__tests__/` (verify
lock): `Test Files 179 passed | 2 skipped (181)`, `Tests 5452 passed | 2
skipped (5454)`.
- `pnpm --filter @object-ui/app-shell type-check` (verify lock; echoes
`@object-ui/app-shell@17.7.0 type-check`, which runs `tsc --noEmit &&
tsc -p tsconfig.test.json`): exit 0, after `turbo run build
--filter='@object-ui/app-shell^...'` built the dependency closure (28 of
28 tasks). `tsc -p tsconfig.test.json --listFilesOnly` lists this test
file. A first run before the closure was built could not resolve the
`@object-ui/*` declarations: NOT MEASURED, not a red.
- `node scripts/check-changeset-presence.mjs`: exit 0 (an empty
frontmatter, the explicit exemption). `check-changeset-no-major.mjs`,
`check-changeset-overwrite.mjs`, `pnpm check:changeset-claims`, `pnpm
check:pending-changeset-literals`: exit 0.
- `pnpm check:new-line-citations`: `0 new citation(s)`, exit 0. `pnpm
check:control-bytes`: exit 0.
- `pnpm check:vi-mock-specifiers`, `check:vi-mock-inherit`,
`check:vi-mock-override-shape`, `check:test-path-roots`: exit 0.
- ESLint, narrowed to the changed file, with an unchanged sibling test
as control: 2 files in the JSON result, 0 errors and 0 warnings each.
`--print-config` shows 119 rules active on the changed file, so it is in
ESLint's population. The config enables no type-aware linting, so this
diff cannot move another file's verdict. The repo-wide `pnpm lint` and
the full sharded `pnpm test` are CI's.

## Acceptance notes

- The sibling test of the same picker,
`HookDefaultInspector.reach-11820.test.tsx`, already waits the way this
change does: its mount helper awaits the roster-labelled checkbox before
any synchronous read.
- objectui#11913 waits on this card (`Blocked-by: #11978`). PR #11972
re-enters the queue once this lands.

Session: `https://claude.ai/code/session_01DBZ9bntPZ7VKyQNtJeNsgw`

---
_Generated by [Claude
Code](https://claude.ai/code/session_01DBZ9bntPZ7VKyQNtJeNsgw)_

Co-authored-by: Claude <noreply@anthropic.com>

Author: objectstack-fleet[bot]

.changeset/11978-hooks-target-label-wait.md

@@ -0,0 +1,4 @@
+---
+---
+
+No release: a test change only. `@object-ui/app-shell`'s `ObjectHooksPanel.newHookTarget-11820` test now waits for the object roster's labels before it reads them. The panel's read of this package's objects and the hook editor's own roster read answer at their own pace, and until the roster answers the selected object is drawn by its bare name (objectui#10585). The test used to read the labels synchronously once the "This package" group appeared, so whether it passed depended on which read answered first (objectui#11978).

packages/app-shell/src/views/studio-design/ObjectHooksPanel.newHookTarget-11820.test.tsx

@@ -83,14 +83,21 @@ describe('ObjectHooksPanel — a new hook (objectui#11820)', () => {
     fireEvent.click(screen.getByRole('button', { name: /New/ }));
     await waitFor(() => expect(mockClient.save).toHaveBeenCalledTimes(1));
 
+    // Two reads answer at their own pace (objectui#11978): the panel's read of
+    // this package's objects draws the "This package" group, and the editor's
+    // own read of the object roster draws the labels and the "Other objects"
+    // group. Until the roster answers, the selected object is drawn by its
+    // bare name — deliberately, it asserts nothing (objectui#10585) — so the
+    // group can be on screen while its checkbox is still named `invoice`.
+    // Every read below whose answer the roster draws waits for it.
     const own = await screen.findByRole('group', { name: 'This package' });
-    expect(within(own).getByRole('checkbox', { name: 'Invoice (invoice)' })).toBeChecked();
-    expect(within(own).getByRole('checkbox', { name: 'Invoice line (invoice_line)' })).toBeInTheDocument();
+    expect(await within(own).findByRole('checkbox', { name: 'Invoice (invoice)' })).toBeChecked();
+    expect(await within(own).findByRole('checkbox', { name: 'Invoice line (invoice_line)' })).toBeInTheDocument();
 
-    const outside = screen.getByRole('group', { name: 'Other objects' });
+    const outside = await screen.findByRole('group', { name: 'Other objects' });
     expect(within(outside).getByTestId('hook-object-outside-reach')).toBeInTheDocument();
-    expect(within(outside).getByRole('checkbox', { name: 'User (sys_user)' })).not.toBeChecked();
-    expect(within(outside).getByRole('checkbox', { name: 'Employee (hr_employee)' })).toBeInTheDocument();
+    expect(await within(outside).findByRole('checkbox', { name: 'User (sys_user)' })).not.toBeChecked();
+    expect(await within(outside).findByRole('checkbox', { name: 'Employee (hr_employee)' })).toBeInTheDocument();
 
     // The package's list was read for THIS package, published and draft.
     expect(mockClient.list).toHaveBeenCalledWith('object', { packageId: PACKAGE });