🌱 Address lint findings in ClusterObjectSet Ready condition work

Convert ceConditionsFromReady to unnamed returns (nonamedreturns) and drop
the unused bool return from setReadyProgressing (unparam). Also document that
ceProgressingFromReady's Archived reason has no meaningful Progressing mapping
and must be guarded by callers.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Per G. da Silva <pegoncal@redhat.com>

Author: Per G. da Silva

internal/object-controller/controllers/clusterobjectset_controller.go

@@ -651,13 +651,14 @@ func setReady(cos *ocv1.ClusterObjectSet, status metav1.ConditionStatus, reason,
 // progress deadline. When the deadline is exceeded it overrides the given
 // (status, reason) with False/ProgressDeadlineExceeded. Callers that must take
 // precedence over the deadline (Blocked, Archived) call setReady directly.
-func setReadyProgressing(l logr.Logger, cos *ocv1.ClusterObjectSet, status metav1.ConditionStatus, reason, message string, isDeadlineExceeded bool) bool {
+func setReadyProgressing(l logr.Logger, cos *ocv1.ClusterObjectSet, status metav1.ConditionStatus, reason, message string, isDeadlineExceeded bool) {
 	if isDeadlineExceeded {
 		l.V(1).Info("progress deadline exceeded", "priorReason", reason)
-		return setReady(cos, metav1.ConditionFalse, ocv1.ClusterObjectSetReasonProgressDeadlineExceeded,
+		setReady(cos, metav1.ConditionFalse, ocv1.ClusterObjectSetReasonProgressDeadlineExceeded,
 			fmt.Sprintf("Revision has not rolled out for %d minute(s). Last status: %s", cos.Spec.ProgressDeadlineMinutes, message))
+		return
 	}
-	return setReady(cos, status, reason, message)
+	setReady(cos, status, reason, message)
 }
 
 // computePhaseDigest computes a deterministic SHA-256 digest of a phase's

internal/operator-controller/controllers/boxcutter_reconcile_steps.go

@@ -107,6 +107,11 @@ const ceAvailableConditionType = "Available"
 
 // ceProgressingFromReady maps a revision's Ready condition reason onto the
 // ClusterExtension's Progressing (status, reason).
+//
+// The Archived reason has no meaningful Progressing mapping: callers must not
+// apply the returned value when ready.Reason is ClusterObjectSetReasonArchived
+// (an archived revision leaves the ClusterExtension's Progressing condition
+// untouched). It therefore falls through to the default here.
 func ceProgressingFromReady(ready metav1.Condition) (metav1.ConditionStatus, string) {
 	switch ready.Reason {
 	case ocv1.ClusterObjectSetReasonReady:
@@ -126,13 +131,13 @@ func ceProgressingFromReady(ready metav1.Condition) (metav1.ConditionStatus, str
 
 // ceConditionsFromReady returns the ClusterExtension Available (Ready retyped)
 // and Progressing (derived) conditions for a revision's Ready condition.
-func ceConditionsFromReady(ready metav1.Condition, generation int64) (available, progressing metav1.Condition) {
-	available = ready
+func ceConditionsFromReady(ready metav1.Condition, generation int64) (metav1.Condition, metav1.Condition) {
+	available := ready
 	available.Type = ceAvailableConditionType
 	available.ObservedGeneration = generation
 
 	ps, pr := ceProgressingFromReady(ready)
-	progressing = metav1.Condition{
+	progressing := metav1.Condition{
 		Type:               ocv1.TypeProgressing,
 		Status:             ps,
 		Reason:             pr,