⚠ remove Progressing condition from ClusterObjectSet (#2952)

Removes the Progressing status condition type from the experimental
ClusterObjectSet (COS) CRD. Progress/retry/block/deadline semantics now
live at the ClusterExtension (CE) layer; COS exposes only health
(Available) and a done latch (status.completedAt). This continues the
direction of #2942 (completedAt in lieu of the COS Succeeded condition)
and prepares for moving Progressing to the upcoming
ClusterObjectDeployment API.

Scope: experimental channel only — COS is experimental-only. No
standard-channel CRD/manifest changes.

- COS controller expresses all rollout state through a single Available
  condition with an expanded reason set, and never writes Progressing.
  Available follows a clear health model: True = healthy, False =
  something is wrong (whether still rolling out or in error), and
  Unknown is reserved solely for the initial state before the first
  reconciliation (never written explicitly by the controller):
    True/ProbesSucceeded          rolled out, all probes pass (paired with completedAt)
    False/ProbeFailure            rolling out, objects failing probes
    False/RollingOut              rolling out, not yet complete
    False/Reconciling             reconcile error prevented observing probes
    False/Blocked                 terminal error, manual intervention required
    False/ProgressDeadlineExceeded deadline exceeded before rollout
    False/Archived                archived / torn down

- operator-controller reconstructs the CE Progressing condition from COS
  Available + completedAt (progressingFromAvailable) instead of mirroring
  COS Progressing. The CE Progressing/Installed public contract is
  preserved on status/reason; reconstruction keys on the Available
  reason, not its status, so the Unknown->False change does not affect
  the CE contract. Archived revisions are excluded from reconstruction.

- Removed the COS Progressing type constant and printcolumn; regenerated
  CRDs, manifests, applyconfigurations, and API reference docs.

- Updated e2e steps and feature files to assert COS Available instead of
  Progressing (ClusterExtension Progressing assertions unchanged).

Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
Co-authored-by: Per G. da Silva <pegoncal@redhat.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: 3 people

api/v1/clusterobjectset_types.go

@@ -26,8 +26,7 @@ const (
 	ClusterObjectSetKind = "ClusterObjectSet"
 
 	// Condition Types
-	ClusterObjectSetTypeAvailable   = "Available"
-	ClusterObjectSetTypeProgressing = "Progressing"
+	ClusterObjectSetTypeAvailable = "Available"
 
 	// Condition Reasons
 	ClusterObjectSetReasonArchived        = "Archived"
@@ -495,19 +494,19 @@ type ClusterObjectSetStatus struct {
 	// conditions is an optional list of status conditions describing the state of the
 	// ClusterObjectSet.
 	//
-	// The Progressing condition represents whether the revision is actively rolling out:
-	//   - When status is True and reason is RollingOut, the ClusterObjectSet rollout is actively making progress and is in transition.
-	//   - When status is True and reason is Retrying, the ClusterObjectSet has encountered an error that could be resolved on subsequent reconciliation attempts.
-	//   - When status is True and reason is Succeeded, the ClusterObjectSet has reached the desired state.
-	//   - When status is False and reason is Blocked, the ClusterObjectSet has encountered an error that requires manual intervention for recovery.
-	//   - When status is False and reason is Archived, the ClusterObjectSet is archived and not being actively reconciled.
+	// The Available condition represents the state of the revision.
+	// True means all objects are at the desired state; False means one or more
+	// objects are not at the desired state; Unknown is the initial state, before
+	// the first reconciliation has evaluated the revision.
+	//   - True with reason ProbesSucceeded: the revision has rolled out and all objects pass their readiness probes.
+	//   - False with reason ProbeFailure: one or more objects are failing their readiness probes during rollout.
+	//   - False with reason RollingOut: the revision is actively rolling out and has not yet become available.
+	//   - False with reason Blocked: the revision has encountered an error that requires manual intervention for recovery.
+	//   - False with reason ProgressDeadlineExceeded: the revision did not roll out within spec.progressDeadlineMinutes.
+	//   - False with reason Reconciling: the revision encountered an error that prevented it from observing the probes.
+	//   - False with reason Archived: the revision has been archived and its objects have been torn down.
 	//
-	// The Available condition represents whether the revision has been successfully rolled out and is available:
-	//   - When status is True and reason is ProbesSucceeded, the ClusterObjectSet has been successfully rolled out and all objects pass their readiness probes.
-	//   - When status is False and reason is ProbeFailure, one or more objects are failing their readiness probes during rollout.
-	//   - When status is Unknown and reason is Reconciling, the ClusterObjectSet has encountered an error that prevented it from observing the probes.
-	//   - When status is Unknown and reason is Archived, the ClusterObjectSet has been archived and its objects have been torn down.
-	//   - When status is Unknown and reason is Migrated, the ClusterObjectSet was migrated from an existing release and object status probe results have not yet been observed.
+	// Rollout completion is recorded separately by status.completedAt.
 	//
 	// +listType=map
 	// +listMapKey=type
@@ -562,7 +561,6 @@ type ObservedPhase struct {
 // +kubebuilder:resource:scope=Cluster
 // +kubebuilder:subresource:status
 // +kubebuilder:printcolumn:name="Available",type=string,JSONPath=`.status.conditions[?(@.type=='Available')].status`
-// +kubebuilder:printcolumn:name="Progressing",type=string,JSONPath=`.status.conditions[?(@.type=='Progressing')].status`
 // +kubebuilder:printcolumn:name=Age,type=date,JSONPath=`.metadata.creationTimestamp`
 
 // ClusterObjectSet represents an immutable snapshot of Kubernetes objects

applyconfigurations/api/v1/clusterobjectsetstatus.go

@@ -132,10 +132,6 @@ func TestStandaloneController(t *testing.T) {
 					assert.Equal(collect, metav1.ConditionTrue, available.Status)
 					assert.Equal(collect, ocv1.ClusterObjectSetReasonProbesSucceeded, available.Reason)
 				}
-				progressing := meta.FindStatusCondition(cos.Status.Conditions, ocv1.ClusterObjectSetTypeProgressing)
-				if assert.NotNil(collect, progressing) {
-					assert.Equal(collect, ocv1.ReasonSucceeded, progressing.Reason)
-				}
 			}, time.Minute, 100*time.Millisecond)
 			cm := &corev1.ConfigMap{}
 			require.NoError(t, cl.Get(ctx, client.ObjectKey{Name: name, Namespace: ns.Name}, cm))

cmd/object-controller/main_test.go

@@ -19,9 +19,6 @@ spec:
     - jsonPath: .status.conditions[?(@.type=='Available')].status
       name: Available
       type: string
-    - jsonPath: .status.conditions[?(@.type=='Progressing')].status
-      name: Progressing
-      type: string
     - jsonPath: .metadata.creationTimestamp
       name: Age
       type: date
@@ -557,19 +554,19 @@ spec:
                   conditions is an optional list of status conditions describing the state of the
                   ClusterObjectSet.
 
-                  The Progressing condition represents whether the revision is actively rolling out:
-                    - When status is True and reason is RollingOut, the ClusterObjectSet rollout is actively making progress and is in transition.
-                    - When status is True and reason is Retrying, the ClusterObjectSet has encountered an error that could be resolved on subsequent reconciliation attempts.
-                    - When status is True and reason is Succeeded, the ClusterObjectSet has reached the desired state.
-                    - When status is False and reason is Blocked, the ClusterObjectSet has encountered an error that requires manual intervention for recovery.
-                    - When status is False and reason is Archived, the ClusterObjectSet is archived and not being actively reconciled.
-
-                  The Available condition represents whether the revision has been successfully rolled out and is available:
-                    - When status is True and reason is ProbesSucceeded, the ClusterObjectSet has been successfully rolled out and all objects pass their readiness probes.
-                    - When status is False and reason is ProbeFailure, one or more objects are failing their readiness probes during rollout.
-                    - When status is Unknown and reason is Reconciling, the ClusterObjectSet has encountered an error that prevented it from observing the probes.
-                    - When status is Unknown and reason is Archived, the ClusterObjectSet has been archived and its objects have been torn down.
-                    - When status is Unknown and reason is Migrated, the ClusterObjectSet was migrated from an existing release and object status probe results have not yet been observed.
+                  The Available condition represents the state of the revision.
+                  True means all objects are at the desired state; False means one or more
+                  objects are not at the desired state; Unknown is the initial state, before
+                  the first reconciliation has evaluated the revision.
+                    - True with reason ProbesSucceeded: the revision has rolled out and all objects pass their readiness probes.
+                    - False with reason ProbeFailure: one or more objects are failing their readiness probes during rollout.
+                    - False with reason RollingOut: the revision is actively rolling out and has not yet become available.
+                    - False with reason Blocked: the revision has encountered an error that requires manual intervention for recovery.
+                    - False with reason ProgressDeadlineExceeded: the revision did not roll out within spec.progressDeadlineMinutes.
+                    - False with reason Reconciling: the revision encountered an error that prevented it from observing the probes.
+                    - False with reason Archived: the revision has been archived and its objects have been torn down.
+
+                  Rollout completion is recorded separately by status.completedAt.
                 items:
                   description: Condition contains details for one aspect of the current
                     state of this API Resource.