Important notices
Is your feature request related to a problem? Please describe.
os-upnp is still using the older static PHP pages (services_upnp.php and status_upnp.php) for its settings and Active Maps UI.
This came up in the recent UPnP forum discussion, where Franco mentioned that the plugin is mostly in community-support mode and is still based on the older static PHP framework. It seems like moving it to the current MVC/API framework would make it a lot easier to maintain going forward.
Describe the solution you'd like
I'd like to look at migrating os-upnp to the current OPNsense MVC/API framework while keeping the existing behavior and configuration working as-is.
I'd definitely aim for feature parity first rather than trying to redesign the plugin or add a bunch of new functionality at the same time.
It seems like the main pieces would probably be:
- configuration model/API
- settings UI
- Active Maps/status UI
- service actions
- migration/compatibility for existing
installedpackages/miniupnpd configuration
I'm happy to help with the work. I'd mostly want some guidance on the preferred direction before getting too far into it, especially around configuration migration and whether it makes more sense to do this incrementally or as one larger migration.
Describe alternatives you've considered
The obvious alternative is to just keep maintaining the existing PHP pages.
That works for now, but it seems like it would leave the plugin increasingly out of step with the rest of OPNsense and make future maintenance harder than it needs to be.
Additional context
This came out of the recent UPnP discussion here:
https://forum.opnsense.org/index.php?topic=52419.30
Franco mentioned that this would probably be a longer-term effort, but that help would be welcome as long as he can provide some guidance.
I'm happy to pitch in if this is something worth moving forward with.
Important notices
Is your feature request related to a problem? Please describe.
os-upnpis still using the older static PHP pages (services_upnp.phpandstatus_upnp.php) for its settings and Active Maps UI.This came up in the recent UPnP forum discussion, where Franco mentioned that the plugin is mostly in community-support mode and is still based on the older static PHP framework. It seems like moving it to the current MVC/API framework would make it a lot easier to maintain going forward.
Describe the solution you'd like
I'd like to look at migrating
os-upnpto the current OPNsense MVC/API framework while keeping the existing behavior and configuration working as-is.I'd definitely aim for feature parity first rather than trying to redesign the plugin or add a bunch of new functionality at the same time.
It seems like the main pieces would probably be:
installedpackages/miniupnpdconfigurationI'm happy to help with the work. I'd mostly want some guidance on the preferred direction before getting too far into it, especially around configuration migration and whether it makes more sense to do this incrementally or as one larger migration.
Describe alternatives you've considered
The obvious alternative is to just keep maintaining the existing PHP pages.
That works for now, but it seems like it would leave the plugin increasingly out of step with the rest of OPNsense and make future maintenance harder than it needs to be.
Additional context
This came out of the recent UPnP discussion here:
https://forum.opnsense.org/index.php?topic=52419.30
Franco mentioned that this would probably be a longer-term effort, but that help would be welcome as long as he can provide some guidance.
I'm happy to pitch in if this is something worth moving forward with.