From 0a4a38e6874db103b794c8c91b1eaa65b7232054 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Maymil?= Date: Thu, 27 Aug 2026 13:54:38 +0200 Subject: [PATCH] security/maltrail: don't override the Check Hostheaders setting The template emitted CHECK_HOST_DOMAINS twice: once from the checkhostheader conditional and again below as a hardcoded false. maltrail's read_config() assigns config[name] = value unguarded while walking the file top to bottom, so the last occurrence won and the GUI toggle never took effect. The hardcoded line predates the option; cdf3620 added the conditional right above it without removing it. Closes #5489 Co-Authored-By: Claude Opus 5 (1M context) --- .../opnsense/service/templates/OPNsense/Maltrail/maltrail.conf | 1 - 1 file changed, 1 deletion(-) diff --git a/security/maltrail/src/opnsense/service/templates/OPNsense/Maltrail/maltrail.conf b/security/maltrail/src/opnsense/service/templates/OPNsense/Maltrail/maltrail.conf index a8d2f72dc2..cd34aaa798 100644 --- a/security/maltrail/src/opnsense/service/templates/OPNsense/Maltrail/maltrail.conf +++ b/security/maltrail/src/opnsense/service/templates/OPNsense/Maltrail/maltrail.conf @@ -59,7 +59,6 @@ CHECK_MISSING_HOST false {% if helpers.exists('OPNsense.maltrail.general.whitelist') and OPNsense.maltrail.general.whitelist != '' %} USER_WHITELIST /usr/local/share/maltrail/misc/user_whitelist.txt {% endif %} -CHECK_HOST_DOMAINS false SHOW_DEBUG false LOG_DIR /var/log/maltrail {% if helpers.exists('OPNsense.maltrail.general.monitorinterface') and OPNsense.maltrail.general.monitorinterface != '' %}