Pull request changed files regression: cannot expand/collapse folders

[lornajane]

Select Topic Area

Bug

GitHub Feature Area

Pull Requests

Body

The files explorer sidebar in pull requests seems to have "lost" some functionality in the last week or two - I'm attaching the screenshot of what Vimium can focus, which no longer includes the folders. Previously the folders could be expanded/collapsed (very helpful for navigating the changed files list, especially for users who can't scroll easily) but this is no longer the case. I'm a keyboard-only user and didn't find any other accessibility tools that did anything different. Could you please take a look?

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[queenofcorgis]

@lornajane thank you for your patience as our engineering team investigated. It looks like this commit broke the functionality. I would recommend opening an issue in Vimium repo as a next step.

[lornajane]

I think the main issue here is that a clickable span that wraps a clickable span doesn't seem like it's intended for accessible access. I have no problems at all in the old-style pull requests view. However in locations which force the new style view such as the commit view you linked in your message, the folders aren't interactive. In this case, they should be interactive elements in their own right if the intention is that the user can interact with them. I'd really appreciate an actual clickable link on an element like that.

[dinalperaketiya]

Hey!

This looks like a recent regression in the pull request file tree UI rather than something on your side.

A couple of things you can try/check:

1. Browser check
   Try a different browser (Chrome/Edge/Firefox) or open in an incognito window to rule out extensions interfering.

2. Clear cache
   Sometimes cached assets can break UI behavior after updates.

3. Keyboard navigation
   If you're using only keyboard, the expand/collapse functionality might currently be affected by an accessibility issue. GitHub has been updating parts of the PR UI recently, so this could be an unintended regression.

4. Temporary workaround
   You can switch to the "Files changed" view without the tree sidebar or use direct file links to navigate until it's fixed.

Since you mentioned it worked before and stopped recently, it's very likely a GitHub-side issue. Reporting it here is the right move 👍

Hope this helps!

[TRKA234]

Hi there,

Thank you for reporting this. As a keyboard-centric user, I understand how critical the expand/collapse folder functionality is for navigating large Pull Requests without relying on a mouse.

It appears that a recent update to the PR File Tree might have changed the DOM structure or the way click listeners are attached, which is why Vimium (and potentially other accessibility tools) is failing to "see" the folders as interactive elements.

While we wait for a permanent fix from the GitHub Engineering team, here are a few workarounds and technical observations:

1. Built-in GitHub Keyboard Shortcuts
   GitHub has native shortcuts for the File Tree that might bypass the need for Vimium hints:

j / k: Move focus up and down the file list.

o or Enter: Expand/Collapse the currently focused folder or open the file.

n / p: Move to the next/previous file in the diff.

Alt + Click (on folder): Still works for some, but if you are keyboard-only, try focusing the folder and using the Right/Left Arrow keys.

2. Technical Insight for the Dev Team
   Looking at the screenshot, Vimium is only highlighting the files (DM, FM, JM, SM), but the tests/schema and fail folder containers are being ignored. This usually happens if:

The folder elements no longer have a role="button" or tabindex="0".

The event listener is attached to a parent div rather than the specific element containing the text/icon.

The interactive area has been swapped for a non-semantic element.

3. Temporary Workaround: "Custom Vimium Hints"
   You can try adding a custom CSS selector to your Vimium settings to force it to recognize these elements. You can add the following to the "Custom key mappings" or check if your CSS selectors for hints include the specific class GitHub uses for the file tree (usually .ActionList-item-label or similar).

Recommendation:
I highly suggest submitting this via the GitHub Accessibility Feedback form as well. They prioritize "keyboard-only" navigation issues highly, especially when it involves a regression in previously working functionality.

Hope this gets resolved soon!