From 6225e7cbb5ecd0f271a5bce1056d0a804ad655bb Mon Sep 17 00:00:00 2001 From: omer-vishlitzky Date: Wed, 12 Aug 2026 11:20:13 +0300 Subject: [PATCH] =?UTF-8?q?OSAC-3954:=20fix=20stale=20comment=20=E2=80=94?= =?UTF-8?q?=20reference=20resolution=20now=20sets=20Id=20and=20Name?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The comment claimed validateAndTransformCluster normalizes references to Id-only, which is no longer true after osac#277 added Name. Assisted-by: Claude Code Signed-off-by: omer-vishlitzky --- .../internal/servers/private_clusters_server.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fulfillment-service/internal/servers/private_clusters_server.go b/fulfillment-service/internal/servers/private_clusters_server.go index 2d179db22..998b0a5f0 100644 --- a/fulfillment-service/internal/servers/private_clusters_server.go +++ b/fulfillment-service/internal/servers/private_clusters_server.go @@ -596,8 +596,7 @@ func (s *PrivateClustersServer) validateTemplateImmutability(ctx context.Context } // Check if template has changed. Compare by refKey (Id) rather than proto.Equal because - // validateAndTransformCluster normalizes the stored reference to Id-only, while the - // reference validator interceptor may backfill Name on incoming requests. + // the reference validator interceptor may backfill additional fields on incoming requests. if updatingTemplate && refKey(existingSpec.GetTemplate()) != refKey(newSpec.GetTemplate()) { return grpcstatus.Errorf( grpccodes.InvalidArgument,