fix(indexes): add schema param to create_index backcompat shim

## Purpose

The `Pinecone.create_index` backcompat shim was missing the `schema`
parameter, silently dropping it even though the canonical `Indexes.create`
already accepts and forwards it. Users calling the legacy flat API could
not pass metadata indexing schemas for serverless or BYOC indexes.

## Solution

Added `schema: dict[str, Any] | None = None` to `Pinecone.create_index`
signature and forwarded it to `self.indexes.create(schema=schema)`. Added
unit tests that mock `_indexes.create` and verify the kwarg is forwarded,
and an integration test using respx that verifies `schema` appears in the
constructed request body under `spec.serverless.schema`.

Author: jhamon

pinecone/_client.py

@@ -524,6 +524,7 @@ def create_index(
         deletion_protection: DeletionProtection | str | None = "disabled",
         vector_type: VectorType | str = "dense",
         tags: Mapping[str, str] | None = None,
+        schema: dict[str, Any] | None = None,
     ) -> IndexModel:
         """Backwards-compatibility shim for :meth:`Pinecone.indexes.create`.
 
@@ -539,6 +540,7 @@ def create_index(
             vector_type=vector_type,
             deletion_protection=resolved_dp,
             tags=tags,
+            schema=schema,
             timeout=timeout,
         )
 

tests/integration/test_client.py

@@ -2,6 +2,7 @@
 
 from __future__ import annotations
 
+import json
 import os
 
 import httpx
@@ -10,6 +11,7 @@
 
 from pinecone import Pinecone
 from pinecone.models.backups.model import CreateIndexFromBackupResponse
+from tests.factories import make_index_response
 
 
 @pytest.mark.integration
@@ -103,3 +105,26 @@ def test_client_init_with_api_key() -> None:
 
     assert isinstance(__version__, str)
     assert len(__version__) > 0
+
+
+@respx.mock
+def test_create_index_schema_parameter_forwarded() -> None:
+    """Verify schema param is forwarded through the create_index backcompat shim."""
+    response_body = make_index_response(name="test-schema-shim")
+    route = respx.post("https://api.pinecone.io/indexes").mock(
+        return_value=httpx.Response(201, json=response_body),
+    )
+
+    pc = Pinecone(api_key="test-key")
+    result = pc.create_index(
+        name="test-schema-shim",
+        spec={"serverless": {"cloud": "aws", "region": "us-east-1"}},
+        dimension=1536,
+        schema={"text_field": {"type": "str"}},
+        timeout=-1,
+    )
+
+    assert result.name == "test-schema-shim"
+    sent_body = json.loads(route.calls[0].request.content)
+    # schema is forwarded into spec.serverless.schema by build_create_body
+    assert sent_body["spec"]["serverless"]["schema"] == {"text_field": {"type": "str"}}

tests/unit/test_create_index_shim.py

@@ -0,0 +1,44 @@
+"""Unit tests for Pinecone.create_index backcompat shim — schema parameter forwarding."""
+
+from __future__ import annotations
+
+from unittest.mock import MagicMock
+
+from pinecone import Pinecone, ServerlessSpec
+
+
+def _make_pc_with_mock_indexes() -> tuple[Pinecone, MagicMock]:
+    pc = Pinecone(api_key="test-key")
+    mock_indexes = MagicMock()
+    mock_indexes.create = MagicMock(return_value=MagicMock())
+    pc._indexes = mock_indexes
+    return pc, mock_indexes
+
+
+def test_create_index_shim_forwards_schema() -> None:
+    """Shim must forward schema kwarg to Indexes.create."""
+    pc, mock_indexes = _make_pc_with_mock_indexes()
+    pc.create_index(
+        name="test",
+        spec=ServerlessSpec(cloud="aws", region="us-east-1"),
+        dimension=1536,
+        schema={"field": {"type": "str"}},
+    )
+
+    mock_indexes.create.assert_called_once()
+    _, kwargs = mock_indexes.create.call_args
+    assert kwargs["schema"] == {"field": {"type": "str"}}
+
+
+def test_create_index_shim_schema_defaults_to_none() -> None:
+    """schema defaults to None when not passed, and None is forwarded to Indexes.create."""
+    pc, mock_indexes = _make_pc_with_mock_indexes()
+    pc.create_index(
+        name="test",
+        spec=ServerlessSpec(cloud="aws", region="us-east-1"),
+        dimension=1536,
+    )
+
+    mock_indexes.create.assert_called_once()
+    _, kwargs = mock_indexes.create.call_args
+    assert kwargs["schema"] is None