Add amp-sticky-ad

[pradeep910]

Add support for amp sticky ad for mobile - https://amp.dev/documentation/components/amp-sticky-ad/

We can add an option in the plugin options page -

• Enable/Disable Sticky Ad
• Adunit name for sticky ad (for example - /35096353/amptesting/formats/sticky)

Enabling this will add amp-sticky-ad that shows at the footer of page.
Out put this markup with dynamic values from options page -

<amp-sticky-ad layout="nodisplay">
  <amp-ad
    width="320"
    height="50"
    type="doubleclick"
    data-slot="/35096353/amptesting/formats/sticky"
  >
  </amp-ad>
</amp-sticky-ad>

[deepaklalwani97]

@pradeep910 Can you share more details on what needs to be done in this issue.

[pradeep910]

@deepaklalwani97 Added description pls let me know if you still have questions.

[deepaklalwani97]

@pradeep910 Should I add fields for height and width to the options page or are we going to use a fixed height and width for the sticky ad. We cannot use multiple breakpoints for the sticky ad as only one sticky ad is allowed per page otherwise it will not show sticky if there are multiple.

[pradeep910]

@deepaklalwani97 Width and height can be passed through function, but ideally it only should show banner / horizontal ads.
The function will set width and height using this sizes attribute or whatever we give in breakpoints like desktop-sizes, tablet-sizes, etc.

$ad_attr = [
						'ad-unit'       => 'GK_Header',
						'desktop-sizes' => '600x90,728x90',
						'tablet-sizes'  => '320x50,468x60',
						'mobile-sizes'  => '320x50,468x60',
						'sizes' => '320x50,728x90',
						'layout'        => 'fixed',
					];

Default should be 320x50

[deepaklalwani97]

@pradeep910 Yes I know my question is we want to pass these sizes as hardcoded in function or provide a setting for the user to add.

[deepaklalwani97]

I have added different sizes according to the devices. Let me know if we want a setting for that. This PR is ready for review #62.

[sagarnasit]

@pradeep910 we should give an attribute option to user for sticky ad where he can specify other attributes as well.

example

AMP_AdManger::get_ads( [
    sticky => true,
    mobile_sizes   => '.....',
    tablet_sizes     => '.....'
    desktop_sizes => '.....'
] );

or
Use separate function for sticky ad when user just have to pass other attributes.

AMP_AdManger::get_sticky_ad( [
    mobile_sizes   => '.....',
    tablet_sizes     => '.....'
    desktop_sizes => '.....'
] );

[pradeep910]

@sagarnasit @deepaklalwani97
I think separate function will be good idea.
Please go ahead with this -

AMP_AdManger::get_sticky_ad( [
    mobile_sizes   => '.....',
    tablet_sizes     => '.....'
    desktop_sizes => '.....'
] );

[deepaklalwani97]

@pradeep910 @sagarnasit I don't think the separate function would make any difference it would just create the redundancy as the code in both the functions would almost be the same. Still, let me know your thoughts and if we want to go ahead with this.

[deepaklalwani97]

@pradeep910 About the size of ads do we want to keep a specific static size for all devices or dynamically passed by the user from settings?

[sagarnasit]

I don't think the separate function would make any difference it would just create the redundancy as the code in both the functions would almost be the same.

@deepaklalwani97 Whole purpose of making a separate function is to make it developer friendly and easy to understand the functionality. Under the hood it will call the get_ads function with required sticky ads attributes so there should not be any redundancy.

About the size of ads do we want to keep a specific static size for all devices or dynamically passed by the user from settings?

We will also need to allow dynamic passing of attributes like we are doing it for normal amp ad.