Repository navigation
Commit b312b5c
committed
Address SQLAlchemy and Datastore warning coverage
Update the dialect for newer SQLAlchemy and Google Datastore client behavior without hiding warnings globally.
Add import_dbapi while keeping dbapi as a compatibility wrapper, and set supports_statement_cache to False so SQLAlchemy does not warn about an unsupported statement cache contract.
Use google.cloud.datastore.query.PropertyFilter in get_columns to avoid the Datastore positional add_filter deprecation path. Adjust integration tests that only need to locate inserted emulator entities so they no longer call the deprecated add_filter form.
Improve the unknown BigQuery type unit test to assert the expected SQLAlchemy SAWarning and NullType fallback. UNKNOWN_TYPE_XYZ is intentionally unsupported in the test fixture, so the warning is part of the expected behavior rather than something to suppress.
Do not raise requires-python to 3.11 in this commit. The current google-cloud-datastore 2.26.0 metadata still supports Python >=3.10; moving this project to Python >=3.11 should be handled as a separate support-policy change because Python 3.10 remains inside the declared project range even though Google now warns about its 2026-10-04 EOL.1 parent 3ec0c7a commit b312b5c
3 files changed
Lines changed: 29 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| |||
54 | 55 | | |
55 | 56 | | |
56 | 57 | | |
| 58 | + | |
57 | 59 | | |
58 | 60 | | |
59 | 61 | | |
| |||
88 | 90 | | |
89 | 91 | | |
90 | 92 | | |
91 | | - | |
| 93 | + | |
92 | 94 | | |
93 | 95 | | |
94 | 96 | | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
95 | 102 | | |
96 | 103 | | |
97 | 104 | | |
| |||
212 | 219 | | |
213 | 220 | | |
214 | 221 | | |
215 | | - | |
| 222 | + | |
216 | 223 | | |
217 | 224 | | |
218 | 225 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
38 | 40 | | |
39 | 41 | | |
40 | 42 | | |
| |||
62 | 64 | | |
63 | 65 | | |
64 | 66 | | |
65 | | - | |
66 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
67 | 71 | | |
68 | 72 | | |
69 | 73 | | |
| |||
332 | 336 | | |
333 | 337 | | |
334 | 338 | | |
335 | | - | |
336 | | - | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
337 | 343 | | |
338 | 344 | | |
339 | 345 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
190 | 191 | | |
191 | 192 | | |
192 | 193 | | |
193 | | - | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
194 | 201 | | |
195 | 202 | | |
196 | 203 | | |
| |||
0 commit comments