Skip to content

RFC: add custom command line switches? (eg --network host) #87

Description

@pataquets

This time, I need to add the --network host switch, and there's no specific defcustom.
However, given the long list of docker build command line switches, I'm wondering if some kind of dockerfile-build-extra-options kind of defcustom would be a better solution for more uncommon options.
Note that I'm not advocating against adding more specific and meaningful dockerfile-build-* options, which would be the best most of the times.
But having to think about an implementation and sending a PR is quite more involved and there's the risk of users "just hacking" the package. Specially if you need a switch temporarily or as a test, before you settle on using it more frequently and you're up to giving the switch some love with a PR.
@drewcsillag WDYT? Any advice/hint before sending the PR? (eg. defcustom name)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions