Skip to content

Commit 7ae8313

Browse files
feat: add request fields to ResourceLimits
1 parent e034b6c commit 7ae8313

3 files changed

Lines changed: 26 additions & 10 deletions

File tree

‎crates/tower-cmd/src/run.rs‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -322,9 +322,12 @@ fn build_cli_execution_spec(
322322
parameters: params,
323323
env_vars,
324324
resources: ResourceLimits {
325-
cpu_millicores: None,
326-
memory_mb: None,
327-
storage_mb: None,
325+
cpu_limit_millicores: None,
326+
cpu_request_millicores: None,
327+
memory_limit_mb: None,
328+
memory_request_mb: None,
329+
storage_limit_mb: None,
330+
storage_request_mb: None,
328331
max_pids: None,
329332
gpu_count: 0,
330333
timeout_seconds: 3600,

‎crates/tower-runtime/src/execution.rs‎

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,17 +114,27 @@ pub enum CacheBackend {
114114
None,
115115
}
116116

117-
/// ResourceLimits defines compute resource constraints
117+
/// ResourceLimits defines compute resource requests and limits.
118+
/// Missing values are resolved by the execution backend.
118119
#[derive(Debug, Clone)]
119120
pub struct ResourceLimits {
120121
/// CPU limit in millicores (e.g., 1000 = 1 CPU)
121-
pub cpu_millicores: Option<u32>,
122+
pub cpu_limit_millicores: Option<u32>,
123+
124+
/// CPU request in millicores
125+
pub cpu_request_millicores: Option<u32>,
122126

123127
/// Memory limit in megabytes
124-
pub memory_mb: Option<u32>,
128+
pub memory_limit_mb: Option<u32>,
129+
130+
/// Memory request in megabytes
131+
pub memory_request_mb: Option<u32>,
125132

126133
/// Ephemeral storage limit in megabytes
127-
pub storage_mb: Option<u32>,
134+
pub storage_limit_mb: Option<u32>,
135+
136+
/// Ephemeral storage request in megabytes
137+
pub storage_request_mb: Option<u32>,
128138

129139
/// Maximum number of processes
130140
pub max_pids: Option<u32>,

‎crates/tower-runtime/tests/subprocess_test.rs‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,12 @@ async fn create_execution_spec(id: String, package: Package) -> ExecutionSpec {
6565
command: None,
6666
},
6767
resources: ResourceLimits {
68-
cpu_millicores: None,
69-
memory_mb: None,
70-
storage_mb: None,
68+
cpu_limit_millicores: None,
69+
cpu_request_millicores: None,
70+
memory_limit_mb: None,
71+
memory_request_mb: None,
72+
storage_limit_mb: None,
73+
storage_request_mb: None,
7174
max_pids: None,
7275
gpu_count: 0,
7376
timeout_seconds: 300,

0 commit comments

Comments
 (0)