Skip to content

Storage lifecycle instances need a shutdown hook #1111

Description

@AlCutter

Description

Instances of storage lifecycle objects usually create background goroutines to perform various operations asynchronously. Currently, these are generally signaled to exit via context cancellation.

This is mostly fine, but occasionally causes issues in tests when things run on longer than they should.

We already have a shutdown hook at the level above which enables the caller to block until work has finished on the entries they've added, it would be good to extend that to allow storage implementation to signal when their background processes have also safely completed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    Status
    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions