Skip to content

STOP USING THIS WRAPPER FOR CODEMIRROR. #43

Description

@liesahead

If you don't want to track memory leak in your application, I suggest you stop using it. All subscriptions on the screenshot are not destroyed when the component is destroyed, so you get 4 leaked subscriptions on each codemirror init, which is causing the slow-down of the application after some time of using it.

image

This wrapper' quality is really poor, just look at the second and third screenshots with comments, those are useless. I'm not hating, but me and my team had to profile and refactor our big app and then we found that this wrapper leaks subscriptions, after we commented codemirror instances app is flying.

image
image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions