Skip to content

fix/4159: Fix sync indexing all public meta when Post Search is disabled #4291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sidsector9 wants to merge 6 commits into
base: develop
Choose a base branch
from
+43 −4
Open

fix/4159: Fix sync indexing all public meta when Post Search is disabled #4291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c833bea
Merge branch 'develop' of github.com:10up/ElasticPress into develop
Sidsector9 Feb 20, 2026
205d32c
Fix meta indexing when Post Search feature is disabled
Sidsector9 Feb 23, 2026
28ce33d
Merge branch 'develop' into fix/4159
Sidsector9 Mar 18, 2026
35b2cf7
Merge branch 'develop' into fix/4159
Sidsector9 Apr 29, 2026
b4f875b
Merge branch 'fix/4159' of github.com:10up/elasticpress into fix/4159
Sidsector9 Apr 29, 2026
bc97018
add unit test
Sidsector9 Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions includes/classes/Indexable/Post/Post.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use WP_User;
use ElasticPress\Elasticsearch;
use ElasticPress\Indexable;
use ElasticPress\Feature\Search\Weighting;

if ( ! defined( 'ABSPATH' ) ) {
// @codeCoverageIgnoreStart
Expand Down Expand Up @@ -852,8 +853,10 @@ public function is_meta_allowed( $meta_key, $post ) {
public function filter_allowed_metas( $metas, $post ) {
$filtered_metas = [];

$search = \ElasticPress\Features::factory()->get_registered_feature( 'search' );
if ( $search && ! empty( $search->weighting ) && 'manual' === $search->weighting->get_meta_mode() ) {
$search = \ElasticPress\Features::factory()->get_registered_feature( 'search' );
$weighting = ( $search && ! empty( $search->weighting ) ) ? $search->weighting : new Weighting();

if ( 'manual' === $weighting->get_meta_mode() ) {
$filtered_metas = $this->filter_allowed_metas_manual( $metas, $post );
} else {
$filtered_metas = $this->filter_allowed_metas_auto( $metas, $post );
Expand Down Expand Up @@ -2552,8 +2555,10 @@ protected function filter_allowed_metas_manual( $metas, $post ) {
return $filtered_metas;
}

$weighting = $search_feature->weighting->get_weighting_configuration_with_defaults();
$is_searchable = in_array( $search_feature, $search_feature->get_searchable_post_types(), true );
$weighting_obj = ( $search_feature && ! empty( $search_feature->weighting ) ) ? $search_feature->weighting : new \ElasticPress\Feature\Search\Weighting();
$weighting = $weighting_obj->get_weighting_configuration_with_defaults();
$is_searchable = $search_feature && in_array( $post->post_type, $search_feature->get_searchable_post_types(), true );

if ( empty( $weighting[ $post->post_type ] ) && $is_searchable ) {
return $filtered_metas;
}
Expand Down
34 changes: 34 additions & 0 deletions tests/php/indexables/TestPost.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4040,6 +4040,40 @@ public function testPrepareMetaManual() {
);
}

/**
* Test that filter_allowed_metas keeps manual mode when the Search
* feature is disabled (its `weighting` property is unavailable).
*
* @since 5.4.0
* @group post
*/
public function testPrepareMetaWithSearchDisabled() {
if ( $this->is_network_activate() ) {
$this->markTestSkipped();
}

$search = ElasticPress\Features::factory()->get_registered_feature( 'search' );
$original_weighting = $search->weighting;
$search->weighting = null;

$post_id = $this->ep_factory->post->create(
[
'meta_input' => [
'test_key1' => 'allowed value',
'not_allowed_key1' => 'disallowed value',
],
]
);

$post = get_post( $post_id );
$prepared_meta = ElasticPress\Indexables::factory()->get( 'post' )->prepare_meta( $post );

$this->assertArrayHasKey( 'test_key1', $prepared_meta );
$this->assertArrayNotHasKey( 'not_allowed_key1', $prepared_meta );

$search->weighting = $original_weighting;
}

/**
* Helper method for filtering private meta keys
*
Expand Down
Loading