test: cover owner checklist, portal-launch recipients, LAN classify - #79
Draft
cursor[bot] wants to merge 1 commit into
Draft
test: cover owner checklist, portal-launch recipients, LAN classify#79cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add deterministic unit tests for previously unclaimed high-risk helpers: checklist patch allowlisting, co-owner/prorate/password launch rules, and LAN/Tailscale interface classification beyond CORS host checks. Co-authored-by: Jose I. Montero <2eezy77@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
VALIDATIONwhen no valid fields; seedDEFAULT_ITEMSuniqueness (ON CONFLICT category key) and mortgage defaults.2026-06-01), owner vs manager/tenant password-skip on send.Test files added/updated
scripts/test-owner-checklist.js(npm run test:owner-checklist)scripts/test-portal-launch-recipients.js(npm run test:portal-launch-recipients)scripts/test-lan-dev-classify.js(npm run test:lan-dev-classify)Why these tests materially reduce regression risk
These paths were unclaimed vs open coverage PRs #66–#78 and sit on money/ops surfaces (owner bill checklist writes, launch credential emails, LAN/Tailscale interface selection). Pure unit tests; no DB/Stripe — safe for cron.
Validation
All passed.