Add missing Speak/Type/Swap languages strings to all locales - #148
Merged
Merged
Conversation
"Speak", "Type" and "Swap languages" were already referenced in the UI but had no entry in any Localizable.strings file, so every locale fell back to the English key. The Type/Speak mode selector is visible text, not just an accessibility label, so non-English users have been seeing English toggle labels. Adds all three keys to all 13 locales. No code change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkRuJrdYaxQVeLiKNhLmgf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"Speak","Type"and"Swap languages"are referenced in the UI but were missing from everyLocalizable.stringsfile, so all 13 locales fell back to the English key."Type"and"Speak"are visible on-screen text — they label the mode selector at the top of the translation screen, which has been rendering in English for every non-English user. This is the user-facing part of the fix."Swap languages"is VoiceOver-only and is never drawn on screen. It is the accessibility label on two glyph-only buttons: the↑↓circle centered inDuoTableModeView, and the⇄circle between the YOU / THEM columns inLanguageSelectionScreen. Sighted users see only the arrow; a Korean VoiceOver user currently hears "Swap languages" in English and will hear 언어 바꾸기 after this change.Adds the three keys to all 13 locales. No code change — the call sites already exist on
main.Provenance
These strings were written while working on #147 (landscape compose-focus layout). That PR is being closed — it caused a rotation hang and a focus/keyboard failure that reproduce on device — but the missing-localization bug it uncovered is real, pre-existing on
main, and independent of any layout work. This PR salvages only that part: strings only, no layout or view changes.Test plan
mise x -- tuist build→ succeededmise x -- tuist test --no-selective-testing→ 10/10TalktransTestspassru"Голос" (literally "voice" — chosen over "Говорить" to match the short toggle-label style) and thezh-Hans/zh-Hant-TWpair.