Issue 6099 - systemd = False has no effect

[vashirov]

Bug Description:
systemd = False doesn't override with_systemd = 1 from defaults.inf when used with dscreate. It is only effective when setup is running in a containerized environment (via dscontainer). But for some special use cases it's important that DS installation runs without systemd.

Fix Description:
Remove the condition for overriding systemd flag.
systemd option is not exposed in the default template, it's listed there only when --advanced flag is used, so it should not affect regular installations.

Fixes: #6099

[vashirov]

dscreate tests in the basic test suite fail because of the assert in the try..except block, it prevents finalizer to run to clean up and remove the instance before the next test. Working on the tests fix...

[vashirov]

This uncovered another issue: server can't be stopped, if it was created with systemd = False. ns-slapd keeps running, because lib389 has no idea that the override existed when the instance was created, and tries to stop it using systemd (because with_systemd = 1 is in the defaults.inf). And we don't expose this in .dsrc.

[mwhahaha]

@vashirov Any update on this? I'm hitting this trying to bootstrap an instance running in a container that mounts host directories and this change seems to be what I need.

[vashirov]

@mwhahaha, sorry, no updates, this fell through the cracks. I will check it next week.

[mwhahaha]

No worries. Actually I looked into this further and there are some other minor issues when running in a container. The pid file is hardcoded to /data/run/slapd-localhost.pid and some other minor stuff. I ended up taking the existing dscontainer script and creating something based off it to handle our environment instead. From a manual configuration for container standpoint, we need the start = false and systemd = false to both work as that's what dscontainer does when trying to initialize fresh instances.

[progier389]

LGTM

[aadhikar]

@vashirov Hey, can you please rebase and merge it?

[vashirov]

@aadhikar, no, it's not ready and not tested properly yet. I converted it to draft, do not merge it yet.