ENH: ASOS code has been refactored using AI - #1050
Merged
Merged
Conversation
Collaborator
|
@AdamTheisen Sounds good! I'll give this a review, might take a bit as its alot of changes |
Collaborator
Author
|
Agreed and no rush! The way we had was good but this code has a lot more checks and functionality |
zssherman
approved these changes
Aug 19, 2026
Collaborator
|
@AdamTheisen This looks good to me! Feel free to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing out some new ideas, I came across issues with the ASOS code where it showed errors for large requests. After putting the errors into ChatGPT, it narrowed it down to the asos.py code in ACT. There were some recent updates to the mesonet API that we use that cause these requests to be rejected.
I utilized ChatGPT to refactor and streamline the code, adding new tests as well. I have reviewed the codes, tested them, and ensure the original unit tests pass before adding in more tests. This new version does improve the time and efficiency of the original unit tests.