Conversation
There was a problem hiding this comment.
Pull request overview
This PR proposes onboarding USDe and sUSDe May 2026 expiry PT (Principal Token) tokens to Aave V3 Ethereum, preparing for the rollover of the previous February 2026 expiry tokens. The proposal uses a direct-to-AIP process with Avalanche as the voting network.
Changes:
- Added configuration for two new PT tokens (PT-USDe-7MAY2026 and PT-sUSDe-7MAY2026) with isolation mode parameters
- Created four new E-Mode categories (two per token: Stablecoins and USDe variants) with specified risk parameters
- Implemented payload contract with asset listings, seed funding, and liquidity mining admin configuration
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| config.ts | Defines asset parameters, E-Mode configurations, and risk parameters for both PT tokens |
| ListingPTEthenaMay_20260129.s.sol | Deployment and proposal creation scripts for the Ethereum mainnet payload |
| ListingPTEthenaMay.md | Technical specification document detailing token parameters, E-Mode settings, and Linear Discount Rate Oracle configurations |
| AaveV3Ethereum_ListingPTEthenaMay_20260129.t.sol | Test suite validating dust bin funding and emission admin configuration for both PT tokens |
| AaveV3Ethereum_ListingPTEthenaMay_20260129.sol | Smart contract payload implementing asset listings, E-Mode creation, and post-execution setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🌈Test ResultsCompiling 262 files with Solc 0.8.27 Solc 0.8.27 finished in 56.33s Compiler run successful! 2026-01-30T16:05:13.454057Z ERROR cheatcodes: non-empty stderr input=["npx", "@bgd-labs/aave-cli@^1.4.5", "diff-snapshots", "./reports/AaveV3Ethereum_ListingPTEthenaMay_20260129_before.json", "./reports/AaveV3Ethereum_ListingPTEthenaMay_20260129_after.json", "-o", "./diffs/AaveV3Ethereum_ListingPTEthenaMay_20260129_before_AaveV3Ethereum_ListingPTEthenaMay_20260129_after.md"] stderr="npm warn exec The following package was not found and will be installed: @bgd-labs/aave-cli@1.4.6\nnpm warn EBADENGINE Unsupported engine {\nnpm warn EBADENGINE package: '@bgd-labs/toolbox@0.2.7',\nnpm warn EBADENGINE required: { node: '>=22' },\nnpm warn EBADENGINE current: { node: 'v20.20.0', npm: '10.8.2' }\nnpm warn EBADENGINE }\n"Ran 5 tests for src/20260129_AaveV3Ethereum_ListingPTEthenaMay/AaveV3Ethereum_ListingPTEthenaMay_20260129.t.sol:AaveV3Ethereum_ListingPTEthenaMay_20260129_Test [PASS] test_dustBinHasPT_USDe_7MAY2026Funds() (gas: 5640590) Ran 1 test suite in 124.06s (124.05s CPU time): 5 tests passed, 0 failed, 0 skipped (5 total tests) |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/20260129_AaveV3Ethereum_ListingPTEthenaMay/ListingPTEthenaMay.md:1
- The e-mode label uses double underscores '__' between the token name and category. For consistency with line 30 which uses 'PT_sUSDe_7MAY2026' without a category suffix, consider using a single underscore or ensuring naming convention is consistent across all e-mode labels.
---
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | -------------------------- | ---------------------------------------------------------------------------------------------------------------------- | | ||
| | initialDiscountRatePerYear | 5.02% | | ||
| | maxDiscountRatePerYear | 25.67% | | ||
| | address | [0xa0dc0249c32fa79e8b9b17c735908a60b1141b40 ](https://etherscan.io/address/0xa0dc0249c32fa79e8b9b17c735908a60b1141b40) | |
There was a problem hiding this comment.
Extra space before closing bracket in the markdown link.
| | address | [0xa0dc0249c32fa79e8b9b17c735908a60b1141b40 ](https://etherscan.io/address/0xa0dc0249c32fa79e8b9b17c735908a60b1141b40) | | |
| | address | [0xa0dc0249c32fa79e8b9b17c735908a60b1141b40](https://etherscan.io/address/0xa0dc0249c32fa79e8b9b17c735908a60b1141b40) | |
| | maxDiscountRatePerYear | 25.67% | | ||
| | address | [0xa0dc0249c32fa79e8b9b17c735908a60b1141b40 ](https://etherscan.io/address/0xa0dc0249c32fa79e8b9b17c735908a60b1141b40) | | ||
|
|
||
| Additionally [0xac140648435d03f784879cd789130F22Ef588Fcd](https://etherscan.io/address/0xac140648435d03f784879cd789130F22Ef588Fcd) has been set as the emission admin both PTs. |
There was a problem hiding this comment.
Missing 'for' between 'admin' and 'both'. Should read 'emission admin for both PTs'.
| Additionally [0xac140648435d03f784879cd789130F22Ef588Fcd](https://etherscan.io/address/0xac140648435d03f784879cd789130F22Ef588Fcd) has been set as the emission admin both PTs. | |
| Additionally [0xac140648435d03f784879cd789130F22Ef588Fcd](https://etherscan.io/address/0xac140648435d03f784879cd789130F22Ef588Fcd) has been set as the emission admin for both PTs. |
a8cf988 to
4891652
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| liqThreshold: '89.2', | ||
| liqBonus: '4.4', | ||
| label: 'PT_USDe_7MAY2026__Stablecoins', | ||
| collateralAssets: ['WETH', 'USDe', 'PT_USDe_5FEB2026'], |
There was a problem hiding this comment.
In the E-Mode configuration for PT_USDe_7MAY2026__Stablecoins, 'WETH' is listed as a collateral asset, but in the corresponding Solidity implementation (lines 66-76 of the .sol file), WETH is not included in the collateral assets array. This inconsistency between the config and implementation will cause incorrect E-Mode behavior.
| collateralAssets: ['WETH', 'USDe', 'PT_USDe_5FEB2026'], | |
| collateralAssets: ['USDe', 'PT_USDe_5FEB2026'], |
| liqThreshold: '88.4', | ||
| liqBonus: '5.5', | ||
| label: 'PT_sUSDe_7MAY2026', | ||
| collateralAssets: ['wstETH', 'sUSDe', 'PT_sUSDE_5FEB2026'], |
There was a problem hiding this comment.
In the E-Mode configuration for PT_sUSDe_7MAY2026, 'wstETH' is listed as a collateral asset, but in the corresponding Solidity implementation (lines 104-114 of the .sol file), wstETH is not included in the collateral assets array. This inconsistency between the config and implementation will cause incorrect E-Mode behavior.
| collateralAssets: ['wstETH', 'sUSDe', 'PT_sUSDE_5FEB2026'], | |
| collateralAssets: ['sUSDe', 'PT_sUSDE_5FEB2026'], |
|
|
||
| | **Asset** | **PT-USDe-7MAY2026** | **PT-USDe-5FEB2026** | **USDe** | **USDC** | **USDT** | **USDtb** | | ||
| | ----------------- | ---------------------- | ---------------------- | ---------------------- | -------- | -------- | --------- | | ||
| | Collateral | Yes | Yes | Yes | No | No | No | |
There was a problem hiding this comment.
The documentation table indicates that WETH should be a collateral asset in the PT-USDe E-Mode, but the corresponding Solidity implementation does not include WETH. This creates a discrepancy between documented and actual behavior.
Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>
Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>
Pre-review checklist: