fix(location): shorten agent location re-check staleness 24h → 2h - #151
Merged
Conversation
An agent that registered before the GeoIP databases existed sat Unverified for up to a day; a re-check is a sub-ms local lookup, and flap protection lives in REGION_CHANGE_STABILITY, so a 2h window is strictly better. 🤖 Built with SMT <smt@agora.build>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An agent that registered before the GeoIP databases existed sat Unverified for up to a day (observed live on prod). A re-check is a sub-ms local mmdb lookup plus one row update, and flap protection lives in REGION_CHANGE_STABILITY (3 consecutive matching observations), not in this window — so 2h is strictly better than 24h.
Verified: 75/75 across location/location-catalog/geoip-refresh suites,
npm run checkclean.Generated with SMT smt@agora.build