feat(android): add Erika native playback with SAF and HDR support#740
Merged
MCDFsteve merged 16 commits intoJul 17, 2026
Conversation
Shinokawa
force-pushed
the
codex/erika-android-support
branch
2 times, most recently
from
July 15, 2026 10:10
2291530 to
0f2312f
Compare
Shinokawa
force-pushed
the
codex/erika-android-support
branch
from
July 16, 2026 18:45
3855225 to
2a80d5e
Compare
Shinokawa
marked this pull request as ready for review
July 17, 2026 04:37
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
FurudeRika123
approved these changes
Jul 17, 2026
MCDFsteve
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content://video sources through Erika's owned file-descriptor path without copying media; selected SAF subtitles remain file-backed through an app-owned cache copy.Dependency
This PR depends on AimesSoft/Erika#42:
be8192d223f32a1bec512b935446999d3694ddfffor reproducible review builds.Runtime validation
Validated on a Pixel 8 / API 36 x86_64 emulator with the current Erika pin lineage:
fontSize/isMepayload compatibility is covered by Erika.Checks
flutter analyze --no-pub --no-fatal-infos --no-fatal-warnings lib test: exit code 0; remaining warnings/info are pre-existing repository diagnostics.AppearanceSettingsProviderdependency.Cross-platform review status
playnon-blocking, bound stalled subtitle subscribers with structured diagnostics, remove a D3D11 panic path, and document the C API physical-pixel migration.Known limitation
Some providers opening files through Android
ACTION_VIEWgrant only temporary read access and do not offer a persistable URI grant. Playback works while that grant remains valid, but reopening the item from history after a process restart may fail. Nipa logs this condition explicitly. Files selected throughACTION_OPEN_DOCUMENTretain permission when the provider supports persistable grants.Do not merge this PR until review is complete.