fix(wmt): use HuggingFace datasets instead of sacrebleu#137
Open
AhmedHammam-AA wants to merge 3 commits into
Open
fix(wmt): use HuggingFace datasets instead of sacrebleu#137AhmedHammam-AA wants to merge 3 commits into
AhmedHammam-AA wants to merge 3 commits into
Conversation
jordisassoon
approved these changes
Dec 19, 2025
jordisassoon
left a comment
jordisassoon
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, I actually really like that now all the hf datasets are taken from HF directly, makes it very clean!
| if split not in [self.SAMPLE_SPLIT, self.FEWSHOT_SPLIT]: | ||
| continue | ||
|
|
||
| # Transform HuggingFace format to expected format |
Collaborator
There was a problem hiding this comment.
could you explain the expected format? specifically with regards to the shuffling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor WMT dataset loading to use sacrebleu instead of HuggingFace datasets.