temperature: add support for fan and power readings - #5233
Open
umtdg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for fan and power readings to the temperature module.
Instead of adding custom modules for my cpu & gpu fan readings and gpu power readings, i was experimenting if i could just add this to the existing temperature module as it already does the heavy lifting by parsing the hwmon path and reading the file.
I've been using my branch for around ~9-10 months now with this config and this config. This was meant to be a quick stitch up at the time and can probably be done better. Any suggestion or anything that i missed in testing/documentation is welcome.
I could only test this on Linux and i don't have the knowledge or environment to implement this for FreeBSD and test.
Related issues
Closes #4681
Checklist
clang-formatninja -C build)man/)