fix(tooltips): only update the tooltip of the hovered module - #5245
Open
rmrfus wants to merge 1 commit into
Open
fix(tooltips): only update the tooltip of the hovered module#5245rmrfus wants to merge 1 commit into
rmrfus wants to merge 1 commit into
Conversation
Since Alexays#5212 every module pokes active_tooltip_->set_markup() on update. That reference is cleared on leave-notify, which is not always delivered when the pointer moves between adjacent modules, so a fast-updating module overwrites the tooltip of whichever module is actually hovered. Check the pointer position instead of trusting leave-notify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #5212 every module pokes
active_tooltip_->set_markup()on update. That reference is cleared on leave-notify, which is not always delivered when the pointer moves between adjacent modules, so a fast-updating module overwrites the tooltip of whichever module is actually hovered.Check the pointer position instead of trusting leave-notify.
What does this PR do?
Hovering one module sometimes flashes a neighbor's tooltip contents. With a lot of custom modules with
interval: 1this creates a significant problem.active_tooltip_is only cleared onleave-notify, which is not always delivered when the pointer moves between adjacent modules, so a fast-updating module overwrites the tooltip of whichever module is actually hovered.This gates the update on the live pointer position instead of trusting
leave-notify, and drops the stale reference when the pointer is elsewhere.Tested for several days on NixOS 26.05 and Fedora 43 (both on sway 1.12) with a several custom modules with
interval: 1.Related issues
No issue filed. The behavior was introduced by #5212.
Checklist
clang-formatninja -C build)man/) - n/a. No new options