Skip to content

TPC: Add CMV processing #15283

Open
rmunzer wants to merge 7 commits intoAliceO2Group:devfrom
rmunzer:tpc_cmc
Open

TPC: Add CMV processing #15283
rmunzer wants to merge 7 commits intoAliceO2Group:devfrom
rmunzer:tpc_cmc

Conversation

@rmunzer
Copy link
Copy Markdown
Contributor

@rmunzer rmunzer commented Apr 16, 2026

No description provided.

@rmunzer rmunzer requested a review from a team as a code owner April 16, 2026 07:22
@rmunzer rmunzer marked this pull request as draft April 16, 2026 07:22
Comment thread prodtests/full-system-test/aggregator-workflow.sh Outdated
@rmunzer rmunzer marked this pull request as ready for review April 23, 2026 07:43
Copy link
Copy Markdown
Collaborator

@ehellbar ehellbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add the formatting suggestions by the format checker.

Comment thread prodtests/full-system-test/aggregator-workflow.sh Outdated
Comment thread prodtests/full-system-test/aggregator-workflow.sh Outdated
Comment thread prodtests/full-system-test/aggregator-workflow.sh Outdated
Comment thread prodtests/full-system-test/aggregator-workflow.sh Outdated
@ehellbar
Copy link
Copy Markdown
Collaborator

you picked up a lot of commits in your latest push. Can you clean it up or rebase it properly, please? :)

add_W o2-tpc-idc-ft-aggregator "--rangeIDC 200 --inputLanes ${lanesFactorize} --nFourierCoeff 40 --nthreads 8"
fi
if [[ $CALIB_TPC_CMV == 1 ]] && [[ $AGGREGATOR_TASKS == TPC_IDCBOTH_SAC || $AGGREGATOR_TASKS == ALL ]]; then
if [[ -z ${O2_TPC_CMV_COMPRESSION:-} ]]; then O2_TPC_CMV_DYNAMIC_PRECISION_MEAN="--cmv-zero-threshold 1.0 --cmv-dynamic-precision-mean 1.0--cmv-dynamic-precision-sigma 8.0 --use-compression-huffman"; fi
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a leftover from your changes. You define O2_TPC_CMV_DYNAMIC_PRECISION_MEAN but check for and later use O2_TPC_CMV_COMPRESSION

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for d7bccc5 at 2026-04-24 18:25:

## sw/BUILD/O2-full-system-test-latest/log
command /sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local15/prodtests/full-system-test/dpl-workflow.sh had nonzero exit code 128
[ERROR] Workflow crashed - PID 13420 (internal-dpl-aod-writer) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device internal-dpl-aod-writer: pid 13420 (exit 128)
[ERROR] SEVERE: Device internal-dpl-aod-writer (13420) returned with 128

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for a2bb660 at 2026-04-24 18:47:

## sw/BUILD/O2-full-system-test-latest/log
command /sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local10/prodtests/full-system-test/dpl-workflow.sh had nonzero exit code 128
[ERROR] Workflow crashed - PID 13413 (internal-dpl-aod-writer) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device internal-dpl-aod-writer: pid 13413 (exit 128)
[ERROR] SEVERE: Device internal-dpl-aod-writer (13413) returned with 128

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants