Skip to content

[O2B-1556] Configure filtering model observability to set active filters to the url#2142

Open
NarrowsProjects wants to merge 115 commits intomainfrom
feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url
Open

[O2B-1556] Configure filtering model observability to set active filters to the url#2142
NarrowsProjects wants to merge 115 commits intomainfrom
feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url

Conversation

@NarrowsProjects
Copy link
Copy Markdown
Collaborator

@NarrowsProjects NarrowsProjects commented Apr 21, 2026

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • When configuring a filter a string version will then appear in the URL

Notable changes for developers:

  • N/A

Changes made to the database:

  • N/A

Guust and others added 30 commits February 20, 2026 10:23
* Filtering by stableBeamsStart and stableBeamsEnd has been added to LHC Fills overview page
* lhcFills endpoint & DTO validation modified and testing added for the aforementioned changes
---------

Co-authored-by: GuustMetz <guust.metz@cern.ch>
Co-authored-by: Guust <metzguust@gmail.com>
* Replaced the two-query pattern with a single queryBuilder in GetAllEnvironmentsUseCase. The previous approach was redundant following Sequelize performance improvements; furthermore, the original implementation's logic was flawed which resulted in the pagination bug.
@NarrowsProjects NarrowsProjects self-assigned this Apr 21, 2026
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Apr 21, 2026
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url branch from 2292724 to e012aa9 Compare April 21, 2026 13:51
…odel-to-extend-FilterModel-or-SelectionModel' into feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url branch from e012aa9 to fda9365 Compare April 21, 2026 13:53
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 4.02299% with 167 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.70%. Comparing base (9e26f06) to head (8806283).

Files with missing lines Patch % Lines
.../Filters/RunsFilter/MultiCompositionFilterModel.js 0.00% 23 Missing ⚠️
...ic/components/Filters/RunsFilter/GaqFilterModel.js 0.00% 22 Missing ⚠️
...public/components/Filters/common/FilteringModel.js 0.00% 21 Missing ⚠️
...onents/Filters/common/filters/ToggleFilterModel.js 0.00% 11 Missing ⚠️
...onents/Filters/common/filters/radioButtonFilter.js 0.00% 8 Missing ⚠️
lib/public/Model.js 0.00% 7 Missing ⚠️
.../components/Filters/common/filters/toggleFilter.js 0.00% 6 Missing ⚠️
...ib/public/views/Runs/Overview/RunsOverviewModel.js 0.00% 6 Missing ⚠️
lib/public/views/Runs/Overview/RunsWithQcModel.js 0.00% 6 Missing ⚠️
lib/public/views/DataPasses/DataPassesModel.js 0.00% 4 Missing ⚠️
... and 25 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2142      +/-   ##
==========================================
- Coverage   45.86%   45.70%   -0.16%     
==========================================
  Files        1038     1037       -1     
  Lines       17173    17156      -17     
  Branches     3115     3110       -5     
==========================================
- Hits         7877     7842      -35     
- Misses       9296     9314      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

"filter[o2end][to]": "1612360800000",
"filter[o2start][from]": "1612350660000",
"filter[o2start][to]": "1612360800000",
"filter[runDuration][limit]": "90000000",
pressElement,
openFilteringPanel,
waitForTableLength,
takeScreenshot,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

2 participants