Repository navigation
Conversation
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
saskiad
reviewed
Oct 1, 2026
saskiad
reviewed
Oct 2, 2026
saskiad
reviewed
Oct 2, 2026
saskiad
reviewed
Oct 2, 2026
saskiad
reviewed
Oct 2, 2026
saskiad
reviewed
Oct 2, 2026
saskiad
left a comment
saskiad
left a comment
Collaborator
There was a problem hiding this comment.
I think there's problem in the test code.
saskiad
reviewed
Oct 2, 2026
| | `ethics_review_id` | `str` | Ethics review ID | | ||
| | `protocol_id` | `Optional[str]` | Protocol ID (DOI for protocols.io) | | ||
| | `injections` | List[[Injection](injection_procedures.md#injection)] | Injections | | ||
| | `injections` | List[[Injection](injection_procedures.md#injection)] | Injections (Use MouseInjectionTargets for common mouse injection sites such as intraperitoneal injection.) | |
Collaborator
There was a problem hiding this comment.
minor: I don't think this is where we want to point people to MouseInjectionTargets
saskiad
reviewed
Oct 2, 2026
| injections: List[Injection] = Field( | ||
| ..., | ||
| title="Injections", | ||
| description="Use MouseInjectionTargets for common mouse injection sites such as intraperitoneal injection.", |
Collaborator
There was a problem hiding this comment.
minor: same as above. This note should really just be for targeted structures and not for the list of Injections itself.
saskiad
reviewed
Oct 2, 2026
| ) | ||
| ], | ||
| targeted_structure=InjectionTargets.RETRO_ORBITAL, | ||
| targeted_structure=mouse_anatomy("Retro-orbital"), |
Collaborator
There was a problem hiding this comment.
but wait, isn't this what we wanted to fix?
Collaborator
There was a problem hiding this comment.
I'm guessing it doesn't matter for this test though, right?
Collaborator
Author
There was a problem hiding this comment.
Fixed this yes, there's still mouse_anatomy now but it's a mock class
saskiad
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds CellLine. In addition it updates biodata-models to the latest v2 version. Because of the breaking changes (removal of ProcessName and *Lookup class renames) there are a lot of other changes that came in. Please take a look carefully to make sure no unexpected changes occurred!