Skip to content

fix: ensure default location value passes validation - #99

Merged
dbirman merged 2 commits into
devfrom
89-location-none-fails-validation
Oct 6, 2026
Merged

dbirman merged 2 commits into
devfrom
89-location-none-fails-validation

Conversation

@dbirman

@dbirman dbirman commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Ensures that the optional location field can still pass validation

@dbirman dbirman linked an issue Oct 5, 2026 that may be closed by this pull request
@dbirman
dbirman requested a review from tmchartrand October 5, 2026 22:06

@tmchartrand tmchartrand left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. seems like a couple unrelated build errors, including needing to set a minimum version to the semver dependency maybe?

@dbirman
dbirman merged commit a56a615 into dev Oct 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metadata.from_metadata default location=None fails validation

2 participants