Support "reverse" in active-group-style for group headers#582
Open
zambetti wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for
reverseinactive-group-styleso the active completion group header can be highlighted reversed.Changes
reverseas a validactive-group-styletoken inlib/-ftb-fzf.reversestyling inlib/ftb-switch-groupusing ANSI SGR: on:7off:27Implementation
The previous implementation relied on hardcoded
casebranches for every style combination (bold,underline,bold,underline, etc.), which was rigid and didn’t scale.This refactor takes a token-based approach, parsing style tokens once, and mapping each to its SGR codes to dynamically build the combined sequence. It also handles
nonemore cleanly by short-circuiting. Ifnoneis present, all other style tokens are discarded and onlynoneis applied, preventing conflicting or redundant formatting states.This keeps behavior consistent while making it easier to extend and maintain.
Example
zstyle ':fzf-tab:*' active-group-style reverse bold