fix: remove unsound Vec transmute in gaussian_blur#276
Open
tmchow wants to merge 2 commits into
Open
Conversation
Replace the `*mut Vec<u8> as *mut Vec<[u8; 4]>` cast with `std::slice::from_raw_parts_mut` to reinterpret the raw byte buffer as `&mut [[u8; 4]]`. Vec has `repr(Rust)` so the old transmute was undefined behavior. Fixes Aloxaf#256
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gaussian_blurfunction casts*mut Vec<u8>to*mut Vec<[u8; 4]>and dereferences it.Vechasrepr(Rust), so this is UB.Replaced the transmute with
std::slice::from_raw_parts_mutto reinterpret the raw byte buffer as&mut [[u8; 4]]instead. Same memory layout, no copies, noset_lencalls.Fixes #256
This contribution was developed with AI assistance (Claude Code).