docs: correct REVIEW.md inaccuracies flagged by automated review by anandgupta42 · Pull Request #984 · AltimateAI/altimate-code

anandgupta42 · 2026-07-05T15:41:03Z

Summary

Follow-up to #983 — corrects a wording inaccuracy in REVIEW.md flagged by automated review (CodeRabbit).

REVIEW.md stated the Marker Guard / altimate_change marker check is "CI-enforced at compile time." It isn't — it's a dedicated marker-guard job in ci.yml (bun run script/upstream/analyze.ts --markers), separate from the typecheck step. The old wording overstated the guarantee and could mislead reviewers about when marker failures actually surface. Fixed to describe it as a CI job, not a compile-time check.

Test plan

Verified via .github/workflows/ci.yml (marker-guard job, line 448) that the marker check runs as its own CI step, not during typecheck/compile.
wc -m REVIEW.md → 9603 (under the 10,000 char budget).

🤖 Generated with Claude Code

Summary by cubic

Corrected REVIEW.md to fix an inaccuracy about Marker Guard enforcement. Clarifies the check is handled by a dedicated CI job (marker-guard in ci.yml), not at compile time.

^{Written for commit 5199576. Summary will update on new commits.}

Summary by CodeRabbit

Documentation
- Clarified the “Marker Guard” guidance to reflect that marker checks are enforced by a dedicated CI job.
- Kept the existing rule to avoid guessing missing markers and to continue flagging incorrect usage.

- Marker Guard is enforced by a dedicated CI job (`marker-guard` in `ci.yml`), not "at compile time" — fixed wording that overstated when marker failures actually surface. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

claude

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

coderabbitai · 2026-07-05T15:41:28Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8361ec3f-e74d-4ec4-9e3c-cd3b7e4422f1

📥 Commits

Reviewing files that changed from the base of the PR and between 6b1dd22 and 5199576.

📒 Files selected for processing (1)

REVIEW.md

📝 Walkthrough

Walkthrough

Updated a single line in REVIEW.md's Marker Guard section, changing the enforcement mechanism description from "compile time" to a dedicated CI job named "marker-guard", while preserving existing guidance on marker handling.

Changes

Documentation update

Layer / File(s)	Summary
Marker Guard wording change `REVIEW.md`	Rewords enforcement description for `altimate_change` marker presence/format from compile-time to the `marker-guard` CI job.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

AltimateAI/altimate-code#983: Prior PR established the initial REVIEW.md guidance on altimate_change marker presence and misuse that this PR further revises.

Poem

A tiny tweak, a single line,
"Compile time" gives way to CI's shine.
The marker-guard now stands on watch,
No missing tags will pass the notch.
Hop along, docs are aligned! 🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description covers Summary and Test Plan, but it omits the required PINEAPPLE header and the Checklist section from the template.	Add PINEAPPLE at the very top, then include a Checklist section with the requested items; keep the existing Summary and Test Plan details.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the change: a docs-only fix to REVIEW.md correcting the Marker Guard wording.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch docs/review-md-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

kilo-code-bot · 2026-07-05T15:43:10Z

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)

REVIEW.md

_{Reviewed by glm-5.2 · Input: 24.7K · Output: 2.4K · Cached: 134.1K}

cubic-dev-ai

No issues found across 1 file

_{Re-trigger cubic}

Merge the 5 commits on `main` since this branch was cut (bearer-auth remote MCP #793, session_start `source` telemetry #968, aireceipts CI #992, REVIEW.md docs #983/#984) into the upstream OpenCode v1.17.9 bridge branch. 9 conflicts resolved: - `altimate/telemetry/index.ts` — keep upstream `InstallationVersion`; re-add #968's `Flag`/`source` (per-session client label). - `session/index.ts` — keep upstream `permission` readonly cast AND #968's `metadata: row.metadata`. Session `metadata` already exists upstream (core `SessionTable`, upstream PR #23068), so #968's persistence layer is redundant. - `session/session.sql.ts` — accept upstream deletion (persistence moved to `@opencode-ai/core`); dropped #968's duplicate migration `20260626041744_elite_malcolm_colcord` (would crash "duplicate column: metadata" against upstream's `20260511173437_session-metadata`). - `test/session/session.test.ts` — keep upstream Effect harness (main's metadata cases were the redundant old-harness variant). - `config/config.ts` — take upstream (schema relocated to core Effect Schema); re-apply #793's `headersCommand`/`oauth` normalize passthrough. - `mcp/index.ts` — re-port #793 (bearer-auth) onto upstream's Effect-based MCP rewrite: `resolveHeadersCommand` (execFile, no shell), case-insensitive `mergeHeaders`, lenient `listTools` retry, OAuth auto-disable folded into upstream's `supportsOAuth`, `maskString` on failures. Adapted `Either`→`Result` (effect 4.0.0-beta.74). - `core/v1/config/mcp.ts` — add `headersCommand` to the Effect Schema `Remote` struct as a mutable non-empty string-array record (`Schema.mutable(...).check (Schema.isNonEmpty())`), so `DeepMutable`-wrapped consumers type-check. - `test/mcp/headers.test.ts`, `test/mcp/mcp-bearer-auth.test.ts` — re-expressed #793's schema/integration tests against the Effect Schema and `it.instance` harness (Zod `safeParse` → `Schema.decodeUnknownSync`). - SDK artifacts kept at the upstream-HEAD baseline (regenerated by CI/release). Verification: all 13 packages typecheck clean (`bun turbo typecheck`); MCP + session + telemetry suites 194/194; bearer-auth + headers 32/32. Zero conflict markers. Marker guard non-strict pass (CI mode for upstream-merge PRs). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

claude Bot reviewed Jul 5, 2026

View reviewed changes

github-actions Bot added the contributor label Jul 5, 2026

cubic-dev-ai Bot reviewed Jul 5, 2026

View reviewed changes

anandgupta42 merged commit bf90e18 into main Jul 5, 2026
23 checks passed

anandgupta42 deleted the docs/review-md-fixes branch July 5, 2026 16:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

docs: correct REVIEW.md inaccuracies flagged by automated review#984

docs: correct REVIEW.md inaccuracies flagged by automated review#984
anandgupta42 merged 1 commit into
mainfrom
docs/review-md-fixes

anandgupta42 commented Jul 5, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

claude Bot left a comment

Uh oh!

coderabbitai Bot commented Jul 5, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

kilo-code-bot Bot commented Jul 5, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

anandgupta42 commented Jul 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by cubic

Summary by CodeRabbit

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

coderabbitai Bot commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

kilo-code-bot Bot commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

anandgupta42 commented Jul 5, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 5, 2026 •

edited

Loading

kilo-code-bot Bot commented Jul 5, 2026 •

edited

Loading