ci: add aireceipts pr-check (notice-only cost receipt)#33
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| check: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - run: npx -y aireceipts-cli@latest pr-check |
There was a problem hiding this comment.
WARNING: Unpinned @latest runs third-party code with pull-requests: write on every PR
npx -y aireceipts-cli@latest resolves to whatever version is published at run time. Since this job grants pull-requests: write and passes GH_TOKEN (github.token), a compromised or broken publish of aireceipts-cli executes automatically against every PR and can post/modify PR comments. Pin to a specific version (and ideally verify integrity) instead of @latest.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| check: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - run: npx -y aireceipts-cli@latest pr-check |
There was a problem hiding this comment.
SUGGESTION: "Never fails a build" guarantee isn't enforced here
The PR describes this as notice-only / "Never fails a build", but a transient npx install failure, registry error, or non-zero CLI exit will turn this check red. Add continue-on-error: true to the step so a notice-only check can never fail the job.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (1 file)
Fix these issues in Kilo Cloud Previous Review Summaries (2 snapshots, latest commit 232b3a6)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 232b3a6)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (1 file)
Fix these issues in Kilo Cloud Previous review (commit d4e7701)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (1 file)
Reviewed by glm-5.2 · Input: 18K · Output: 7.5K · Cached: 143.6K |
| check: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - run: npx -y aireceipts-cli@0.5.0 pr-check |
There was a problem hiding this comment.
SUGGESTION: "Never fails a build" guarantee isn't enforced here
The PR describes this check as notice-only / "Never fails a build", but a transient npx install failure, registry error, or non-zero CLI exit will mark this check red and can block PR merges. Add continue-on-error: true to the step so a notice-only check can never fail the job.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
|
Hi @andreahlert — could one of you give this a quick review + approve when you get a moment? 🙏 It's a notice-only aireceipts cost-receipt check (a single |
|
Hi @ppradnesh 👋 — friendly nudge as the top contributor here. This is a lightweight aireceipts dogfood PR (part of an org-wide rollout). It adds a notice-only CI is green. Could you give it a quick review + merge when you have a moment? (It needs one approving review from someone with write access — admin bypass is off here.) Happy to answer any questions. Thanks! 🙏 |
|
Thanks for the automated review — addressed:
Intentional, left as-is:
|
1 participant
Adds a notice-only aireceipts cost-receipt check (pr-check) — one self-contained workflow, no external reusable workflow, no org Actions-policy change. Never fails a build; posts an aireceipts cost receipt only once a branch carries an aireceipts receipt ref, otherwise a quiet no-op. Coexists with any existing check; remove anytime by deleting the file. Part of an org-wide aireceipts dogfood.
Note
Low Risk
Adds an isolated CI workflow with read-only repo access plus PR comment permissions; it cannot fail the build and does not touch application code.
Overview
Adds a new GitHub Actions workflow
.github/workflows/aireceipts.ymlthat runs on every pull request.On each PR it runs
npx -y aireceipts-cli@latest pr-checkwithGH_TOKENandpull-requests: writeso the CLI can post a cost receipt when the branch has an aireceipts receipt ref; otherwise it no-ops. The step usescontinue-on-error: true, so the check is notice-only and does not fail the workflow. Concurrency cancels in-progress runs per ref.Reviewed by Cursor Bugbot for commit de9ba4f. Bugbot is set up for automated code reviews on this repo. Configure here.