Fix link and image rules failing to match due to invalid POSIX regex …#2
Open
heshammahamed wants to merge 2 commits into
Open
Fix link and image rules failing to match due to invalid POSIX regex …#2heshammahamed wants to merge 2 commits into
heshammahamed wants to merge 2 commits into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The link
[label](url)and imagerules in never produced<a>or<img>tags. The regexes used\x5D(hex for]) and\x5B(hex for[) in character classes, which are PCRE/Perlextensions not supported by the POSIX
regcompused inSrl.Regex.Fix
Replace the invalid hex escapes with POSIX-compatible equivalents:
[^\n\x5D]→[^]\n]— placing]first after[^is thestandard POSIX way to include a literal
]in a negated class\x5B→[—[needs no escaping inside a character class