feat: modern JSON Schema support — $defs, dependentSchemas, dependentRequired (C37) - #1181
Merged
Merged
Conversation
…Required (C37) Normalize d4-d7 dependencies into dependentSchemas + dependentRequired during compound conversion. All versions now use the same compound fields for comparison. - D4/D6/D7 converters split dependencies (schema→dependentSchemas, string-array→dependentRequired) via CompoundSchemaConverter.splitDependencies - CompoundSchemaDiffVisitor: add diffFullSchemaDependentRequired and diffFullSchemaDependentSchemas with key tracking - visitFullSchemaDependentSchema: compatibility-aware schema comparison - Remove flagModernVersions — 2019-09/2020-12 no longer flagged as unsupported - $defs: handled by auto-recursion (same as definitions)
8 new test cases: - $defs basic compatibility (2019-09) - dependentSchemas add/remove (2019-09) - dependentRequired add/remove members (2019-09) - Cross-version: d7 dependencies vs 2019-09 dependentSchemas - Cross-version: d7 dependencies (string-array) vs 2019-09 dependentRequired - 2019-09 and 2020-12 basic schema compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dependenciesintodependentSchemas+dependentRequiredduring compound conversionCompoundSchemaConverter.splitDependenciesdiffFullSchemaDependentSchemas: key tracking + compatibility-aware schema comparisondiffFullSchemaDependentRequired: key tracking + string-array set comparison$defs: handled by auto-recursion (same pattern asdefinitions)flagModernVersions— 2019-09/2020-12 no longer flagged as unsupportedContext
C37 in #1042. First step of modern JSON Schema version support.
Test plan