Repository navigation
Fix Jellyfin + Bonfire build and app id - #68
Merged
PatrickSt1991 merged 2 commits intoOct 8, 2026
Merged
Conversation
…v12.2 The jellyfin-web switch left the build without the Tizen client (config.xml, tizen.js, gulp step that creates www/), so the Bonfire loader curl failed with exit 23. Build jellyfin-tizen again and clone jellyfin-web v12.2 in pre_build. Node 24 now comes from setup-node. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jellyfin-tizen's config.xml uses AprZAARz4r.Jellyfin, the id of the official store app, which conflicts when installing. Rewrite the package/app id to JellyBnfir and rename the app to Jellyfin Bonfire. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Jellyfin + Bonfire entry, whose CI build is failing on
main(run 37810716332).jellyfin/jellyfin-webthe build never fetchesjellyfin-tizen, so there is noconfig.xml,tizen.js, or gulp step that createswww/.curl -o www/bonfire-loader.jsthen fails with exit 23.branch: masteronjellyfin-webis also the 13.0.0 development version, not a release.jellyfin__jellyfin-web.jsonback tojellyfin__jellyfin-tizen.jsonand setsrepotojellyfin/jellyfin-tizen.pre_buildclonesjellyfin-webatv12.2, builds it, and runsJELLYFIN_WEB_DIR=../jellyfin-web/dist npm cito createwww/. Node 24 comes from the existingsetup-nodestep, so thenpm exec node@24wrapper is gone.output_nameisJellyfin-Bonfire.wgt, with no spaces.config.xmlusesAprZAARz4r.Jellyfin, the same id as the official store app, which breaks installing.pre_buildnow rewrites it toJellyBnfir(idJellyBnfir.Jellyfin) and renames the app to Jellyfin Bonfire. Agrepfails the build if the rewrite did not apply.