Jak and Daxter: Lock PME requirement to 1.6.0. - #6345
Closed
massimilianodelliubaldini wants to merge 2 commits into
Closed
Jak and Daxter: Lock PME requirement to 1.6.0.#6345massimilianodelliubaldini wants to merge 2 commits into
massimilianodelliubaldini wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
waiting-on: peer-review
duckboycool
reviewed
Jul 19, 2026
duckboycool
added
is: maintenance
Co-authored-by: Duck <31627079+duckboycool@users.noreply.github.com>
duckboycool
added
waiting-on: peer-review
duckboycool
approved these changes
Jul 19, 2026
duckboycool
left a comment
duckboycool
left a comment
Collaborator
There was a problem hiding this comment.
Confirmed at least being able to open the client with this version installed. Probably somebody should test actually playing the game though.
Contributor
Author
|
1.6.0 is the version of the library that I have tested on for a little while now, so my only concern would be like, a brand new install of AP with this requirements file to see if it pulls 1.6.0 instead of 2.0.0. |
nicholassaylor
approved these changes
Jul 21, 2026
nicholassaylor
left a comment
nicholassaylor
left a comment
Contributor
There was a problem hiding this comment.
Spun up a VM installing with this PR and it correctly installs 1.6.0
Contributor
Author
|
Nick the GOAT, thank you! |
duckboycool
added
waiting-on: core-review
Soggy-Pancake
added a commit
to Soggy-Pancake/ArchipelaGOAL3-Linux
that referenced
this pull request
Aug 2, 2026
Collaborator
|
Indeed is superceded. |
github-actions
Bot
removed
the
waiting-on: core-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
PyMemoryEditor 2.0.x is incompatible with 1.6.x. Jak's requirements file specifies
>=1.6.0so this will accidentally grab the later version, which won't work with the way Jak's client is currently written. We'll lock the version to=1.6.0until a future update where we can move the whole client to 2.0.x.The reason we're not doing that now is there's an active beta world for Jak and I don't want to have multiple versions of the world that require different versions of the same library.
How was this tested?
Not at all.
If this makes graphical changes, please attach screenshots.
N/A.