fix(consensus): voter-list corruption and duplicate round-validator slots#1349
Open
oXtxNt9U wants to merge 8 commits into
Open
fix(consensus): voter-list corruption and duplicate round-validator slots#1349oXtxNt9U wants to merge 8 commits into
oXtxNt9U wants to merge 8 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1349 +/- ##
===========================================
+ Coverage 59.10% 59.33% +0.22%
===========================================
Files 968 972 +4
Lines 65587 66016 +429
Branches 1835 1915 +80
===========================================
+ Hits 38768 39168 +400
- Misses 26579 26606 +27
- Partials 240 242 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
the tail's. The old code corrupted the voter linked list, letting any voter crash nodes via a getVotes out-of-bounds panic. - calculateRoundValidators: revert with InsufficientActiveValidators when there are fewer distinct active validators than the round size, instead of padding slots with duplicates — duplicate slots can never be signed (validatorIndex is not in the signed message), orphaning them and halting consensus.
18f4d3c to
8bf6b65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist