Repository navigation
Render a read-only terminal monitor across supported clients - #71
armstrongsam25 wants to merge 8 commits into
Conversation
Pi-Agent-Run: 4ddf7cb0-8cdd-497f-b0aa-7a5a410104f3 CI-Round: 1
Pi-Agent-Run: 4ddf7cb0-8cdd-497f-b0aa-7a5a410104f3 CI-Round: 2
Pi-Agent-Run: 4ddf7cb0-8cdd-497f-b0aa-7a5a410104f3 CI-Round: 3
|
Reviewed
The two native failures are candidate-specific fixture/test defects, not a reason to discard the implementation. No merge or issue-completion claim yet. |
|
Fixed both failing native terminal-monitor tests in
This PR stays draft while exact-head protected CI and real web terminal acceptance with Deep#439 complete. Native live journeys are waived by the maintainer; native implementation/contract parity and protected checks remain in scope. The existing Deep branch also needs the missing authenticated monitor binding; that repair is underway using this existing contract. |
|
Final native lifecycle repair is pushed as The full local portable Qt exit139 and unavailable host pinned formatter remain explicit limits. This draft requires fresh final-head protected native/web workflows and composed web verification before merge. Native live is owner-waived; automated gates are unchanged. |
|
Pushed the next frozen review update, Local checks: workflow114 pass/4 existing skips, protocol/provenance21 pass/1 existing skip, converter12 pass, exact offline Android test compilation and ktlintCheck pass. No device execution or fresh coverage measurement is claimed yet. Current-pin composed web acceptance and final review remain required. Native live verification is owner-waived; automated gates are retained. Draft and auto-merge disabled. |
Related to #48
Adds the shared read-only terminal list/monitor across web, Windows, Android and Apple clients, with bounded literal output, truncation and safe read-only lifecycle handling.
Final review found stale terminal display/replay across Apple disconnects and Windows chat transitions. Candidate
697e68efeabdcbe6384bc4203fb7d3a541b110e4fixes all three findings, plus timer/refresh retirement and Apple conversation changes. Terminal requests use the closed current-connection transport, reject queuing/replay, clear private display/generations on disconnect/auth loss/timeouts and bind replies to the current conversation. Independent scoped review approves the nine-file repair; existing native transformation provenance is updated.Repair evidence: Core330 passes; macOS app440 passes/1 skip; the final-tip hosted SurfaceView refresh→real timeout→late-frame→fresh-retry regression passes. Qt owning cohort178 passes. Changed-line diagnostics cover Python3/3 and Swift61/61. Fresh unsigned iOS/watch builds pass for unchanged runtime bytes in the final test-only descendant. All commands finished. The full local portable Qt run exited139 and remains failed/incomplete; narrow current/baseline checks do not replace it. Host Xcode27.1 cannot load the pinned26.6 formatter configuration; protected pinned/native workflows remain mandatory.
Previous f23 protected workflows and real composed web terminal acceptance passed, including small/large hostile output, truncation, narrow layout, owner isolation, stale sessions, disconnect and account switch. These remain source-bound historical receipts; fresh final-head protected qualification and current-pin composed web verification remain required before merge. Native live verification is explicitly waived by the owner; implementation and automated/protected gates are not waived. Draft with auto-merge disabled. No release/store/production deployment.
Final test/report-retention update
b364f3452309e92724840715e4cdaae795686dd9leaves runtime code unchanged. All three protected workflows passed on697, but their raw reports exposed unexecuted Android code-rendering lines and missing exported producer inputs. Four new owning Compose instrumentation scenarios cover literal multiline rendering, content precedence/fallback and actual platform selection/copy with no server action. Existing coverage producers now retain Python/Windows/C#/raw browser observations using the existing converter and pinned artifact action; gate commands, assertions, retries, permissions and timeouts remain unchanged.Local owning checks: workflow114 passed/4 existing platform skips; protocol/provenance21 passed/1 existing immutable-source replay skip; converter12 passed. Exact final Android test compilation and ktlintCheck pass offline with one worker/512MiB; no emulator run occurred. Previous task-resolution/test-import failures are retained. Fresh instrumented execution, coverage matrix, independent final review and current-pin composed web acceptance remain pending. This update is draft with auto-merge disabled and makes no new coverage-threshold, merge or release claim.