fix: print-env when missing data - #44
Open
Cifko wants to merge 2 commits into
Open
Conversation
porkbrain
reviewed
May 27, 2024
porkbrain
reviewed
May 27, 2024
| let package = context.unwrap_package_id(); | ||
| let atoma_db = context.get_or_load_atoma_db().await?; | ||
| let manager_badge = context.get_or_load_db_manager_badge().await?; | ||
| let atoma_db = context.get_or_load_atoma_db().await.ok(); |
Contributor
There was a problem hiding this comment.
How did you encounter this error anyway? There should always be atoma DB and manager badge if you provide a correct package ID. Not sure if we should be silent on the error because that means something went very wrong.
Collaborator
Author
There was a problem hiding this comment.
when I register a node from a non admin account
Contributor
There was a problem hiding this comment.
Doesn't matter if it's non admin or not, everyone needs to know atoma DB and everyone can know it. What error did you get? Can you replicate? You cannot register a node without knowing the object ID of the DB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When missing some data, print everything you can instead of failing.