HYDRA-2275 : Update HVT to recent main - #476
Conversation
debloip-adsk
changed the title
Co-authored-by: Julia B. Grenier <julia.grenier@mail.mcgill.ca>
debloip-adsk
changed the title
| } | ||
| } | ||
| } | ||
| // Leave renderParams.camera empty so HVT renders through its free camera |
There was a problem hiding this comment.
This sound will break the custom attribute support, if the free camera is used (renderParams.camera was set as empty), the custom camera attributes from Maya will not be applied as the free camera is a different HdCamera item under the hood if I recall correctly.
There was a problem hiding this comment.
That's why we want the HdCamera with Maya attributes (including custom) to be set to renderParams.camera, we can log another ticket to track the wrong values issue if it's hard to solve
There was a problem hiding this comment.
Hm so I wasn't too involved in the whole custom attributes work, but I have two things in mind :
- The free camera is different than the renderParams camera, but I also know that the cameraPath we were setting here was never actually used for the actual rendering by HVT, it always used the free camera regardless. So there should be no change in behavior in that regard. Unless setting renderParams.camera was required to do the custom attributes translation itself to Hydra scene index, I think this won't change the existing behavior
- I see in testCustomAttributes.cpp we seem to test the custom attributes translation for cameras, and the preflights passed so I'm assuming it's not breaking it? Unless the unit tests are not testing what you are referring to
There was a problem hiding this comment.
ok, if HVT always used the free camera, then it's not a problem for this PR. Please log a ticket to track, thanks!
There was a problem hiding this comment.
Logged as HYDRA-2485. Thanks!
debloip-adsk
added
the
ready-for-merge
3 participants
Uh oh!
There was an error while loading. Please reload this page.