HYDRA-2429 : Pass OCIO configuration file path to Hydra render delegate - #485
Merged
Merged
Conversation
ppt-adsk
reviewed
Aug 3, 2026
| (settingsMapRenderSettingsSrc) \ | ||
| (hydraSceneRenderSettingsSrc) | ||
| (hydraSceneRenderSettingsSrc) \ | ||
| (adsk_ocioPath) // Autodesk-specific OCIO config path (no standard Hydra token). |
Collaborator
There was a problem hiding this comment.
Since this is purely our convention, and the risk of collision is probably nil, I wonder if could just call it ocioConfigPath. And I think it should be ocioConfigPath rather than ocioPath.
Collaborator
Author
There was a problem hiding this comment.
I agree, will change it to that.
Collaborator
Author
|
Preflight passed, Windows 2027 coverage build failed from timeouts. Re-ran build and passed, see Branch Preflight - Coverage - 2027 (Windows) #731. |
ppt-adsk
approved these changes
Aug 4, 2026
benyoon-adsk
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To allow proper interpretation of color management color space names and other color management information, both the Hydra renderer and the application must refer to the same OCIO configuration file. Pass this information to render delegate's settingsMap via SetRenderSetting(). No unit test will be added as per the discussion with Pierre.