HYDRA-2483 - Move dg_access_mutex down to where it's actually needed - #489
Open
vlasovi wants to merge 1 commit into
Open
HYDRA-2483 - Move dg_access_mutex down to where it's actually needed#489vlasovi wants to merge 1 commit into
vlasovi wants to merge 1 commit into
Conversation
lilike-adsk
approved these changes
Aug 14, 2026
lilike-adsk
left a comment
lilike-adsk
left a comment
Collaborator
There was a problem hiding this comment.
Nice, we can continue to add lock if there's any missing place
vlasovi
added
the
ready-for-merge
ppt-adsk
approved these changes
Aug 17, 2026
ppt-adsk
left a comment
ppt-adsk
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just a couple of minor questions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current placement of dg_access_mutex is too high in the stack. In case where many rprims updated, this prevents full multithreading of Hydra's SyncAll. This change moves the mutex down to the methods that actually access Maya DG.