USD prim holdouts in Viewport 2.0 - #4681
Open
marceloserchelihh wants to merge 21 commits into
Open
Conversation
…sn't render wireframe
|
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Trust Commitment requirement. |
Collaborator
|
@marceloserchelihh Thank you for the PR and the submitting the signed CLA. As a cleanup step would it be possible for you to squash the commits (and force push back to PR)? We don't use squash and merge so cleaning up so many commits first is preferred. Can you also add some documentation in this PR describing your change. Sean |
seando-adsk
added
the
do-not-merge-yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue https://github.com/Autodesk/maya-usd/issues/3125
Adds support for rendering a USD prim as a holdout.
In my opinion, the proper solution would be to be able to add a MHWRender::MRenderItem to the 'holdOutList', but from my understanding, that API is not available. I will add a more robust explanation and details in the issue page, stating the approach taken here.