EMSUSD-4019 renderer provider

[pierrebai-adsk]

• Added validation of the command success when retrieving the display label of a renderer.
• Moved private functions to be completely private.
• Added a function to return a name-indexed map of renderers for faster access by name.
• Added scan of the storm renderers registry.
• This also allows merging renderers with the same name reported by different APIs.
• This also fixes the problem that Maya-Hydra was not correctly reported as a Hydra renderer by the Maya renderer command.
• Modified currentRenderer and switchRenderer to read and write the current renderer from the SceneRenderDescription.
• This becomes the fallback value if for any reason the Maya global renderer node is not found or is empty.
• Added unit tests for MayaRendererProvider.

[Copilot]

Pull request overview

Adds unified renderer discovery and current-renderer handling for Maya Render Setup.

Changes:

• Merges Maya and Hydra renderer registries.
• Adds SceneRenderDescription fallback and switching logic.
• Adds Windows-based Maya integration tests.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
lib/usd/ui/renderSetup/mayaRendererProvider.h	Expands and exports the provider API.
lib/usd/ui/renderSetup/mayaRendererProvider.cpp	Implements merged discovery and dual-store selection.
test/lib/usd/ui/renderSetup/testMayaRendererProvider.cpp	Tests discovery and renderer switching.
test/lib/usd/ui/renderSetup/main.cpp	Initializes Maya for tests.
test/lib/usd/ui/renderSetup/CMakeLists.txt	Defines the test executable.
test/lib/usd/ui/CMakeLists.txt	Includes Render Setup tests conditionally.
test/lib/usd/CMakeLists.txt	Adds the UI test subtree.
render-setup-renderer-provider-plan.md	Documents the design and implementation.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Suppressed comments (3)

Previously missed (3) — in code that hasn't changed since the last review.

test/lib/usd/ui/renderSetup/CMakeLists.txt:26

• The executable unconditionally loads mayaUsdPlugin, but BUILD_ADSK_PLUGIN is an optional build setting and is the condition that creates/installs that plugin. With it disabled, this test is still registered and always exits at startup because the plugin is unavailable. Gate the test on the plugin build as well.

if(IS_WINDOWS AND MAYA_HAS_USD_SETTINGS_NODES)

lib/usd/ui/renderSetup/mayaRendererProvider.cpp:34

• std::map is used by getRenderersMap(), but this translation unit never includes <map> and currently depends on an unrelated Maya/USD header including it transitively. Include the standard header directly so this continues to compile if those implementation-detail includes change.

#include <maya/MSelectionList.h>
#include <maya/MStatus.h>
#include <maya/MStringArray.h>

lib/usd/ui/renderSetup/mayaRendererProvider.h:34

• These public class docs do not match the implementation: switchRenderer() writes every selection to defaultRenderGlobals (lines 278-283), and currentRenderer() reads that store first, using the USD settings node only as a fallback. Describing separate “appropriate” stores can lead callers to read or update the wrong source.

//! Reads and writes the current renderer from the appropriate store:
//! - Hydra renderers: UsdSettingsNode::currentRenderer attribute
//! - Legacy renderers: defaultRenderGlobals.currentRenderer attribute