EMSUSD-4019 renderer provider - #4718
Merged
antonkhelou merged 4 commits intoAug 27, 2026
Merged
Conversation
- Added validation of the command success when retrieving the display label of a renderer. - Moved private functions to be completely private. - Added a function to return a name-indexed map of renderers for faster access by name. - Added scan of the storm renderers registry. - This also allows merging renderers with the same name reported by different APIs. - This also fixes the problem that Maya-Hydra was not correctly reported as a Hydra renderer by the Maya renderer command. - Modified `currentRenderer` and `switchRenderer` to read and write the current renderer from the SceneRenderDescription. - This becomes the fallback value if for any reason the Maya global renderer node is not found or is empty. - Added unit tests for MayaRendererProvider. - Made usage of `sceneRenderDescription` conditional on its availability. - Added more code to validate that a given `Hydra` renderer is available. - Avoid using possibly invalid renderer name when switching renderers. - Update the global settings last since that is what triggers updates elsewhere. - Added clases to automatically hold and release Hydra-related pointers.
seando-adsk
reviewed
Aug 26, 2026
seando-adsk
reviewed
Aug 26, 2026
seando-adsk
reviewed
Aug 26, 2026
seando-adsk
reviewed
Aug 26, 2026
seando-adsk
reviewed
Aug 26, 2026
seando-adsk
reviewed
Aug 26, 2026
seando-adsk
requested changes
Aug 26, 2026
seando-adsk
left a comment
Collaborator
There was a problem hiding this comment.
Overall good. Just a couple of minor things to fix and a couple of questions.
- Removed copyrights in cmake files. - Trying to build C++ test on all platforms. - Using MayaUsd Namespace. - Using a std::string instead of a const char*
seando-adsk
approved these changes
Aug 27, 2026
antonkhelou
deleted the
bailp/EMSUSD-4019/renderer-provider-enhancements
branch
August 27, 2026 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currentRendererandswitchRendererto read and write the current renderer from the SceneRenderDescription.sceneRenderDescriptionconditional on its availability.Hydrarenderer is available.