Skip to content

EMSUSD-4019 renderer provider - #4718

Merged
antonkhelou merged 4 commits into
devfrom
bailp/EMSUSD-4019/renderer-provider-enhancements
Aug 27, 2026
Merged

EMSUSD-4019 renderer provider#4718
antonkhelou merged 4 commits into
devfrom
bailp/EMSUSD-4019/renderer-provider-enhancements

Conversation

@pierrebai-adsk

Copy link
Copy Markdown
Collaborator
  • Added validation of the command success when retrieving the display label of a renderer.
  • Moved private functions to be completely private.
  • Added a function to return a name-indexed map of renderers for faster access by name.
  • Added scan of the storm renderers registry.
  • This also allows merging renderers with the same name reported by different APIs.
  • This also fixes the problem that Maya-Hydra was not correctly reported as a Hydra renderer by the Maya renderer command.
  • Modified currentRenderer and switchRenderer to read and write the current renderer from the SceneRenderDescription.
  • This becomes the fallback value if for any reason the Maya global renderer node is not found or is empty.
  • Added unit tests for MayaRendererProvider.
  • Made usage of sceneRenderDescription conditional on its availability.
  • Added more code to validate that a given Hydra renderer is available.
  • Avoid using possibly invalid renderer name when switching renderers.
  • Update the global settings last since that is what triggers updates elsewhere.
  • Added classes to automatically hold and release Hydra-related pointers.

- Added validation of the command success when retrieving the display label of a renderer.
- Moved private functions to be completely private.
- Added a function to return a name-indexed map of renderers for faster access by name.
- Added scan of the storm renderers registry.
- This also allows merging renderers with the same name reported by different APIs.
- This also fixes the problem that Maya-Hydra was not correctly reported as a Hydra renderer by the Maya renderer command.
- Modified `currentRenderer` and `switchRenderer` to read and write the current renderer from the SceneRenderDescription.
- This becomes the fallback value if for any reason the Maya global renderer node is not found or is empty.
- Added unit tests for MayaRendererProvider.
- Made usage of `sceneRenderDescription` conditional on its availability.
- Added more code to validate that a given `Hydra` renderer is available.
- Avoid using possibly invalid renderer name when switching renderers.
- Update the global settings last since that is what triggers updates elsewhere.
- Added clases to automatically hold and release Hydra-related pointers.
@pierrebai-adsk pierrebai-adsk added the shared_components Shared Components (Max / Maya) label Aug 25, 2026
@pierrebai-adsk pierrebai-adsk self-assigned this Aug 25, 2026
Comment thread test/lib/usd/ui/renderSetup/CMakeLists.txt Outdated
Comment thread test/lib/usd/ui/renderSetup/testMayaRendererProvider.cpp Outdated
Comment thread test/lib/usd/ui/renderSetup/testMayaRendererProvider.cpp Outdated
Comment thread test/lib/usd/ui/CMakeLists.txt
Comment thread test/lib/usd/ui/renderSetup/CMakeLists.txt Outdated
Comment thread lib/usd/ui/renderSetup/mayaRendererProvider.cpp

@seando-adsk seando-adsk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good. Just a couple of minor things to fix and a couple of questions.

@pierrebai-adsk pierrebai-adsk removed their assignment Aug 26, 2026
- Removed copyrights in cmake files.
- Trying to build C++ test on all platforms.
- Using MayaUsd Namespace.
- Using a std::string instead of a const char*
@pierrebai-adsk pierrebai-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Aug 27, 2026
@antonkhelou
antonkhelou merged commit feb7a6d into dev Aug 27, 2026
13 checks passed
@antonkhelou
antonkhelou deleted the bailp/EMSUSD-4019/renderer-provider-enhancements branch August 27, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge Development process is finished, PR is ready for merge shared_components Shared Components (Max / Maya)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants