EMSUSD-4085 remove change block from committer - #4724
Merged
Conversation
The `SdfChangeBlock` delays stage recomposition. This prevents USD-level API from working correctly. For example, `DefinePrim` fails because it does not see the prim it just created. `SdfChangeBlock`should be used by the code doingthe work when they deem it safe, knowing exactly which API they are using. `Sdf`-level API are save, `Usd` are not.
pierrebai-adsk
added
bug
pierrebai-adsk
requested review from
ppt-adsk and
seando-adsk
and removed request for
seando-adsk
August 27, 2026 16:08
ppt-adsk
reviewed
Aug 27, 2026
ppt-adsk
approved these changes
Aug 27, 2026
pierrebai-adsk
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SdfChangeBlockdelays stage recomposition. This prevents USD-level API from working correctly. For example,DefinePrimfails because it does not see the prim it just created.SdfChangeBlockshould be used by the code doing the work when they deem it safe, knowing exactly which API they are using.Sdf-level API are safe,Usdare not.