Skip to content

Resync gizmo body on parent object move [SYNTH-334] - #1484

Merged
PepperLola merged 3 commits into
devfrom
branp/334/resync-gizmo-body
Aug 17, 2026
Merged

Resync gizmo body on parent object move [SYNTH-334]#1484
PepperLola merged 3 commits into
devfrom
branp/334/resync-gizmo-body

Conversation

@BrandonPacewic

Copy link
Copy Markdown
Member

Task

SYNTH-334

Symptom

GizmoSceneObject caches ceach rigid body's transform relative to the gizmo once at construction. If the parent object moves afterward through something other than the gizmo that cache goes stale and causes the gizmo to be out of sync with its assigned component.

Solution

Allow for the ability to sync the gizmo to its parent for usage when you want to be able to move the parent component and the attached gizmo at the same time.

Verification

Gizmo behaves normally. We currently do not have any callers that need this functionality. But we will for MAM. Since that pr stack is already going to be quite large I decided to move this into its own chunk.


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@BrandonPacewic BrandonPacewic self-assigned this Aug 6, 2026
@BrandonPacewic
BrandonPacewic requested a review from a team as a code owner August 6, 2026 22:01
@BrandonPacewic
BrandonPacewic requested a review from a team as a code owner August 6, 2026 22:01
/**
* Re-seats the gizmo on its parent after something other than this gizmo moved the parent.
*/
public syncToParent() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to mark this as unused so people know not to remove it.

Comment thread fission/src/systems/scene/GizmoSceneObject.ts

@AlexD717 AlexD717 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PepperLola
PepperLola merged commit 0a219c9 into dev Aug 17, 2026
24 checks passed
@PepperLola
PepperLola deleted the branp/334/resync-gizmo-body branch August 17, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants